92479 - nsPersistentProperties reads 1 byte at a time.

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

nsPersistentProperties reads one char at a time from the input stream.  This
should be change to read and process a block at a time.

Comment 1

[Doug Turner (:dougt)]

Attachment: Reads chunk in from the stream at a time.

Comment 2

[Doug Turner (:dougt)]

ack. bad patch.  I am reallocating when I don't have too...

Comment 3

[Doug Turner (:dougt)]

Attachment: only deallocate in ~()

Comment 4

[Doug Turner (:dougt)]

hey chris, can you look at this patch?  

Comment 5

[Chris Waterson]

Wow, so...how many times do we buffer this data now? (I'd have thought the whole
point of nsIUnicharInputStream would've been to buffer the data.) Would it be
better to do the buffering there?

I notice that |ConverterInputStream| (in nsUnicharInputStream.cpp) has an
|nsIUnicharBuffer| member: is this not working right?

Comment 6

[Doug Turner (:dougt)]

I should have marked this bug dependent on 

http://bugzilla.mozilla.org/show_bug.cgi?id=92477.


ignore for now...  I need to get results.

Comment 7

[Suresh Duddi (gone)]

Doug ? Seems wrong to make this mozilla1.0 This looks like it can give a sizable
perf improvement.

Comment 8

[Doug Turner (:dougt)]

It was marked m1.0 because 93055 was.  I see that Darin moved it up.  

Darin, do you want to see if you can fix up these two callers (92477 and this)

Comment 9

[Doug Turner (:dougt)]

to darin.  This should be changed along with the changes to support partial
reads

Comment 10

[Darin Fisher]

is this really a big performance problem?  NS_NewConvertStream returns a input
stream that has a buffer.  therefore, reading one byte at a time is not really
all that costly.

i also don't believe that this change would be blocked by bug 93055.

resolving WONTFIX unless someone can show that this will actually help.  IMO
this is only bloat.