nsPersistentProperties reads 1 byte at a time.

RESOLVED WONTFIX

Status

()

Core
XPCOM
RESOLVED WONTFIX
17 years ago
17 years ago

People

(Reporter: dougt, Assigned: Darin Fisher)

Tracking

({perf})

Trunk
mozilla1.0
x86
Windows 2000
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
nsPersistentProperties reads one char at a time from the input stream.  This
should be change to read and process a block at a time.
(Reporter)

Updated

17 years ago
Summary: nsPersistentProperties read 1 byte at a time. → nsPersistentProperties reads 1 byte at a time.
(Reporter)

Updated

17 years ago
Blocks: 7251

Updated

17 years ago
Keywords: perf
(Reporter)

Comment 1

17 years ago
Created attachment 44007 [details] [diff] [review]
Reads chunk in from the stream at a time.
(Reporter)

Comment 2

17 years ago
ack. bad patch.  I am reallocating when I don't have too...
(Reporter)

Comment 3

17 years ago
Created attachment 44008 [details] [diff] [review]
only deallocate in ~()
(Reporter)

Comment 4

17 years ago
hey chris, can you look at this patch?  
Keywords: patch

Comment 5

17 years ago
Wow, so...how many times do we buffer this data now? (I'd have thought the whole
point of nsIUnicharInputStream would've been to buffer the data.) Would it be
better to do the buffering there?

I notice that |ConverterInputStream| (in nsUnicharInputStream.cpp) has an
|nsIUnicharBuffer| member: is this not working right?
(Reporter)

Comment 6

17 years ago
I should have marked this bug dependent on 

http://bugzilla.mozilla.org/show_bug.cgi?id=92477.


ignore for now...  I need to get results.
Depends on: 92477
(Reporter)

Updated

17 years ago
Target Milestone: --- → mozilla0.9.4

Updated

17 years ago
No longer blocks: 7251

Updated

17 years ago
Blocks: 7251
(Reporter)

Updated

17 years ago
Target Milestone: mozilla0.9.4 → mozilla0.9.5
(Reporter)

Updated

17 years ago
Target Milestone: mozilla0.9.5 → mozilla1.0
(Reporter)

Updated

17 years ago
Blocks: 98275

Comment 7

17 years ago
Doug ? Seems wrong to make this mozilla1.0 This looks like it can give a sizable
perf improvement.
(Reporter)

Comment 8

17 years ago
It was marked m1.0 because 93055 was.  I see that Darin moved it up.  

Darin, do you want to see if you can fix up these two callers (92477 and this)
(Reporter)

Comment 9

17 years ago
to darin.  This should be changed along with the changes to support partial
reads
Assignee: dougt → darin
(Assignee)

Comment 10

17 years ago
is this really a big performance problem?  NS_NewConvertStream returns a input
stream that has a buffer.  therefore, reading one byte at a time is not really
all that costly.

i also don't believe that this change would be blocked by bug 93055.

resolving WONTFIX unless someone can show that this will actually help.  IMO
this is only bloat.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.