924791 - Mouse hover effect offset

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[saad.inam92]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0 (Beta/Release)
Build ID: 20131001023928

Steps to reproduce:

USing the HP slatebook x2 dock (keyboard and mouse) I open any web page (in firefox beta).
I move my mouse pointer over something that should have a hover effect(like a drop down menu), but it doesnt open, or have its effect. If I move my mouse lower and to the right, the hover effect on an item displays. i.e. the trigger for the hover effect is missplaced significantly to the top left. 


Actual results:

The hover effect did not trigger when I hovered my mouse over a drop down menu, or any other item that has a hover effect. Only when I lowered the point to the right and down, the hover effect triggered.


Expected results:

When I place my mouse ponter over an item with a hover effect, it should be triggered.

Comment 1

[saad.inam92]

Attachment: tmp_Screenshot_2013-10-09-04-30-511719041581.png

This shows that when the pointer is placed below and to the right of the home like, the hover effect of the link is activated. Hovering the cursor over the home link does not do this.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: WIP

Uncompiled, untested patch.

https://tbpl.mozilla.org/?tree=Try&rev=a7746dc64e05

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Here's one that compiles. Untested though since I don't have a device that accepts mouse input.

https://tbpl.mozilla.org/?tree=Try&rev=1710ee55568d

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Hi saad, can you verify that the build at [1] fixes the problem? You should be able to install the build on your device if you check the option to allow untrusted app sources in the Android settings. The build will show up on your device as "Nightly" and will be separate from your Firefox Beta install. You can uninstall Nightly after you're done without affecting your existing Firefox Beta app or profile.

[1] http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-1710ee55568d/try-android/fennec-27.0a1.en-US.android-arm.apk

Comment 5

[saad.inam92]

Comfirmed working!

Tested on different websites, passed 100%.

Great work, Thanks.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Thanks for confirming. The patch isn't in the tree yet, but we will mark this bug fixed once it lands.

Comment 7

[Wesley Johnston (:wesj)]

I'll try to reivew Monday (I have a machine that can take a mouse there).

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/fx-team/rev/43807e2ed283

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 815378 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 803207
User impact if declined: In Fennec, if a mouse is attached the hover events are sent to the wrong position on hi-dpi devices
Testing completed (on m-c, etc.): on m-c, verified by reporter and wesj
Risk to taking this patch (and alternatives if risky): fairly low risk - i understand the code well and there's a pretty low chance of unintended side effects. It affects Fennec only.
String or IDL/UUID changes made by this patch: none

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/43807e2ed283

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 815378 [details] [diff] [review]
Patch

We'll take this because:

1) it's a 25 regression in mobile and we should avoid
2) if it regresses mouse ability further, we wouldn't chemspill

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Has merge conflicts with Aurora. Please attach a branch-specific patch for uplift.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Rebased and landed on aurora and beta:

https://hg.mozilla.org/releases/mozilla-aurora/rev/396f4f51ae40
https://hg.mozilla.org/releases/mozilla-beta/rev/e77fd9718e2a

Comment 14

[Kartikaya Gupta (email:[e-mail])]

A follow-up to fix bustage (rebase fail):

https://hg.mozilla.org/releases/mozilla-aurora/rev/bea15f8d3098
https://hg.mozilla.org/releases/mozilla-beta/rev/95125f37d679

Comment 15

[Aaron Train [:aaronmt]]

Verified with a Micro USB OTG dongle and USB mouse, this now works.