924801 - [Buri][SMS][Call]Can't recognize phone number with symbols before the number.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[sync-1]

Mozilla build ID:20130916041201
 
 Created an attachment (id=529938)
 picture1
 
 DEFECT DESCRIPTION:
 Can't recognize phone number with symbols before the number.
 
  REPRODUCING PROCEDURES:
 1、Enter messaging app->Receive messages containing symbols before number;
 2、Read messages such as (XXXXXXXXXXX->It appears ( symbol before number in dialing interface->KO1;
 3、Read messages such as )/?/@/%/?XXXXXXXXXXX->Can't recognize phone number->KO2;
 
 
  EXPECTED BEHAVIOUR:
 KO1:It should only exist phone number;
 KO2:It can read number even though there exist symbols before number.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 Medium
  REPRODUCING RATE:
 5/5
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: picture1

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: log+531483

Comment 5

[sync-1]

Clone from brother

Comment 6

[sync-1]

Attachment: picture2

Comment 7

[Julien Wajsberg [:julienw]]

Do you know if that's something new (ie a regression) or if it never worked ?

Also, which Gaia hash please ?

Comment 8

[xiupinglong]

As I known, it is not a regression.

Comment 9

[Julien Wajsberg [:julienw]]

xiupinglong> can you share your gaia hash please ?

Comment 10

[Jason Smith [:jsmith]]

Removing qawanted comment 8 - not a regression.

Comment 11

[xiupinglong]

(In reply to Julien Wajsberg [:julienw] (in MozSummit until next monday) from comment #9)
> xiupinglong> can you share your gaia hash please ?

Build ID: 20130916041201
Gaia:  8b20ff956f8e366a17a7ef5f64935a6a6a8cb0c0

Comment 12

[Julien Wajsberg [:julienw]]

I really think we should support the "(<phonenumber>)" case. Asking to block for 1.3 then.

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

triage: would not block release. add to backlog

Comment 14

[Kodanda rami reddy V]

Hi Julienw, 

Please assign this issue to me. With the current design, sms app allows only symbols  \s,:;\(>  before a number to be recognised as a phone number terming as safeStart. please suggest more symbols to be added to his safeStart. 

Regards,
Ramu.

Comment 15

[Julien Wajsberg [:julienw]]

Corey, can you suggest some characters to add to safeStart?

I think '(' is a must, maybe '/' too.
Also, do you think that using '(' would give issues, because it's then used in the capturing regexp?

Comment 16

[Corey Frang [:gnarf]]

( is already a safe start, < maybe needs to be as well... / makes some sense.  The test case here provides a ? as well.  Really its mostly about evaluating them on a case by case basis.. Does it make sense for: "?1231231234" to make 1231231234 a dialable number? etc.

Comment 17

[Julien Wajsberg [:julienw]]

Ah I remember now, case 1 is that we should try to _not_ match an initial '(' if it's not matched by a ')'. Not sure how we can do this efficiently.

Comment 18

[kumar rishav (:rishav_)]

Hey Julien,
As the discussion is very old, i would like ask to get more clear.
I want to know, how to decide what is safe character or not. As we are selecting number (dialable number) from message, Message can have any character. We need to pick only those what satisfy for a dialable number.
Not exactly same, but it's related to https://bugzilla.mozilla.org/show_bug.cgi?id=1120572 ,  basically we want identify allowable number.

I had a look on format of phone number. There are lot's of format of telephone number. Are we going handle all those format. If no, then what all formats we are considering.

Thanks

Comment 19

[Julien Wajsberg [:julienw]]

I think we try to handle most phone number formats from a message.


See comment 17 for what we should try to do for case 1, and for case 2 I'm not really sure about what we want to do, I'd like to see reports from actual users, or to see what other systems are doing for such cases...

Comment 20

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 21

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(