924878 - codemirror.css should be in skin, not in content

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect, P3)

Comment 1

[mcdavis941 (sporadically reading bugmail)]

Please, yes.

Comment 2

[Paul Rouget [:paul]]

Is this actually really needed? Afaik, nobody ever built themes for Orion.


But I imagine it doesn't cost much to move the files to /themes/shared/.

Comment 3

[Anton Kovalyov (:anton)]

Are there any advantages of putting CSS files into /themes/ besides customization? I'd like CodeMirror to not be customizable at least for the initial release and until we flesh out all the kinks.

Comment 4

[Paul Rouget [:paul]]

(In reply to Anton Kovalyov (:anton) from comment #3)
> Are there any advantages of putting CSS files into /themes/ besides
> customization? I'd like CodeMirror to not be customizable at least for the
> initial release and until we flesh out all the kinks.

Not really. I agree with you, for the moment, we should favor self-contained + maintainable code over customization.

Comment 5

[Alfred Kayser]

A solution for me would to also include a chrome://browser/skin/devtools/codemirror.css, initially empty, so that themers can at least provide overriding style rules when needed.

Examples where this is needed are my themes, particulary Walnut and Walnut2 where the grey linenumbers column just doesn't fit the Walnut style.

See also the documentation on the CodeMirror site, where one of the key advantages mentioned is the style customizability of CodeMirror.

Right now there is there no way that a theme can adjust styling of the CodeMirror based scratchpad.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Not in scope for first release but definitely something we can do once we've stabilized. Thanks!

Comment 7

[Alfred Kayser]

This is more or less solved by: Bug 895561 - "Edit As HTML" option in the markup view,
by adding the common.css into the codemirror context, so that now themers can apply their own styling on top of the CodeMirror style.

 const CM_STYLES   = [
+  "chrome://browser/skin/devtools/common.css",
   "chrome://browser/content/devtools/codemirror/codemirror.css",
   "chrome://browser/content/devtools/codemirror/dialog.css",
   "chrome://browser/content/devtools/codemirror/mozilla.css"
 ];