Closed Bug 924882 Opened 11 years ago Closed 11 years ago

test_setup_active_sync needs extra wait for setup screen

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

x86_64
Linux
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: bsilverberg)

References

Details

Attachments

(2 files)

I'm not seeing any new setup screen. The test usually passes on my device but I did get a failure or two. I think we just need to add a wait here. I am working on a PR for that.
Assignee: nobody → bob.silverberg
Summary: test_setup_active_sync needs extra work for new setup screen → test_setup_active_sync needs extra wait for setup screen
Attachment #815046 - Flags: review?(zcampbell)
Attachment #815046 - Flags: review?(moz.teodosia)
Attachment #815046 - Flags: review?(andrei.hutusoru)
Attachment #815046 - Flags: review?(alin.trif)
(In reply to Bob Silverberg [:bsilverberg] from comment #1)
> I'm not seeing any new setup screen. The test usually passes on my device
> but I did get a failure or two. I think we just need to add a wait here. I
> am working on a PR for that.

Probably right - I didn't run the test locally I just tried to interpret the CI test run results!
Comment on attachment 815046 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12762

Although the test was passing for me before this wait, this wait does not affect in any bad way the test.
tested it locally -> pass!
Attachment #815046 - Flags: review?(alin.trif) → review+
Comment on attachment 815046 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12762

LGTM
Attachment #815046 - Flags: review?(andrei.hutusoru) → review+
Comment on attachment 815046 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12762

Runs spiffingly on Hamachi!
Attachment #815046 - Flags: review?(zcampbell)
Attachment #815046 - Flags: review?(moz.teodosia)
Attachment #815046 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/a8316cbe21d8fed926e87fb026c36487b86fded4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 826355 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13318

Uplifting to v1.2
Attachment #826355 - Flags: review?(zcampbell)
Attachment #826355 - Flags: review?(trifandreialin)
Attachment #826355 - Flags: review?(moz.teodosia)
Attachment #826355 - Flags: review?(florin.strugariu)
Attachment #826355 - Flags: review?(andrei.hutusoru)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 934130
Attachment #826355 - Flags: review?(zcampbell)
Attachment #826355 - Flags: review?(trifandreialin)
Attachment #826355 - Flags: review?(moz.teodosia)
Attachment #826355 - Flags: review?(florin.strugariu)
Attachment #826355 - Flags: review?(andrei.hutusoru)
Attachment #826355 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/1faebcda33ed0d51e8300e5b76ff23066eaaf541
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: