Closed Bug 924891 Opened 7 years ago Closed 7 years ago

don't use JS_BITS_PER_WORD in jscrashreport.cpp

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: froydnj, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
We really mean to use some flavor of x86ish-ness here; JS_BIT_PER_WORD is not
the correct conditional.

Not sure who really owns the code, but r?'ing Waldo for general preprocessor
stuffs.
Attachment #814859 - Flags: review?(jwalden+bmo)
Blocks: 781171
Better patch that compiles and even fixes uses in #if 0 code.
Attachment #814859 - Attachment is obsolete: true
Attachment #814859 - Flags: review?(jwalden+bmo)
Attachment #815161 - Flags: review?(jwalden+bmo)
Comment on attachment 815161 [details] [diff] [review]
don't use JS_BITS_PER_WORD in jscrashreport.cpp

Review of attachment 815161 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review.  Looks ok, though we have JS_CPU_{X86,X64} which might be better... we are inconsistent, but those ones are used more often than __i386__ or _M_IX86.
Attachment #815161 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/ceef564c96d8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.