924983 - [AccessFu] Support range widget adjustment with up/down swipes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Introduce context actions

Up/down will be used for more than just range widgets, but here is a start.

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 814960 [details] [diff] [review]
Introduce context actions

This looks good for a start. Equally, if not even more, important are things like moving by character or word, esp in FF OS, which should also be supported by this up down swipe I think. I do not think it is useful to tie left and right swipes to different granularities like Android does.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 814960 [details] [diff] [review]
Introduce context actions

Review of attachment 814960 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great! r=me with the tiniest nits.

::: accessible/src/jsat/content-script.js
@@ +329,5 @@
> +function adjustRange(aMessage) {
> +  function sendUpDownKey(aAccessible) {
> +    let evt = content.document.createEvent('KeyboardEvent');
> +    let keycode = aMessage.json.direction == 'forward' ?
> +          content.KeyEvent.DOM_VK_DOWN : content.KeyEvent.DOM_VK_UP;

Nit: too many spaces.

@@ +332,5 @@
> +    let keycode = aMessage.json.direction == 'forward' ?
> +          content.KeyEvent.DOM_VK_DOWN : content.KeyEvent.DOM_VK_UP;
> +    evt.initKeyEvent(
> +      "keypress", false, true, null, false, false, false, false, keycode, 0);
> +    if (aAccessible.DOMNode)

NIT: {} around the if statement.

Comment 4

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/15dc352386e8

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/15dc352386e8