Closed
Bug 924991
Opened 11 years ago
Closed 11 years ago
Trickle ICE candidates use the wrong index
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: ekr, Assigned: ekr)
Details
Attachments
(1 file)
|
932 bytes,
patch
|
abr
:
review+
|
Details | Diff | Splinter Review |
From Mallinath at Google: In the message, the "label" which corresponds to m-line index is starting with 1. In this example it's 1 for audio and 2 for video . But as per the JSEP spec it should be same as the m-line index which always starts with 0.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ekr
|
|
Assignee | |
Updated•11 years ago
|
Attachment #814975 -
Flags: review?(adam)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 814975 [details] [diff] [review] Fix trickle ICE indexes Review of attachment 814975 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #814975 -
Flags: review?(adam) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/73b479deee54
https://hg.mozilla.org/mozilla-central/rev/73b479deee54
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•