Closed Bug 924995 Opened 7 years ago Closed 7 years ago

Story - Use same base app name so that it uses the same profile and more

Categories

(Firefox for Metro Graveyard :: Browser, defect, P2)

x86_64
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 28

People

(Reporter: bbondy, Assigned: emtwo)

References

Details

(Whiteboard: [completed-oak] [block28] feature=story c=tbd u=tbd p=1)

Attachments

(1 file, 4 obsolete files)

We should use the same app base name when we share the same profile, so that it uses the same profile dir, and so that other things work as expected.

To do this we should set this:
http://dxr.mozilla.org/mozilla-central/source/browser/metro/metroapp.ini.in#l4

Because of this:
http://dxr.mozilla.org/mozilla-central/source/browser/confvars.sh#l6

We should just be able to do:
Name=@MOZ_APP_BASENAME@

p=1
bbondy: so I think you need to add the define here: http://dxr.mozilla.org/mozilla-central/source/browser/metro/Makefile.in#l19

bbondy: the define would look like this: http://dxr.mozilla.org/mozilla-central/source/webapprt/Makefile.in#l31
Attached patch Patch to share profile data (obsolete) — Splinter Review
Attached file firefox.exe (obsolete) —
Here's the build. This is pretty neat!
Attached file metroapp.ini.in (obsolete) —
Brian pointed out.. that was my local build so if someone wants to try it, they'd need to swap their metroapp.ini.in with this one. I will post a proper build.
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/msamuel@mozilla.com-c6b67e2a81b2/try-win32/firefox-27.0a1.en-US.win32.installer.exe

To try this, install in a different directory that doesn't already contain a Nightly because of bug 928432.
Attachment #818637 - Flags: review?(netzen)
Attachment #818637 - Flags: review?(netzen) → review+
Whiteboard: [oak-only]
Summary: Work - Use same base app name so that it uses the same profile and more → Story - Use same base app name so that it uses the same profile and more
Whiteboard: [oak-only] → [oak-only] feature=story c=tbd u=tbd p=1
Whiteboard: [oak-only] feature=story c=tbd u=tbd p=1 → [oak-only] [block28] feature=story c=tbd u=tbd p=1
https://hg.mozilla.org/projects/oak/rev/14bcd0194c56
Whiteboard: [oak-only] [block28] feature=story c=tbd u=tbd p=1 → [completed-oak] [block28] feature=story c=tbd u=tbd p=1
Assignee: nobody → msamuel
Blocks: metrov1it18
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Landed on oak here:
https://hg.mozilla.org/projects/oak/rev/14bcd0194c56

Bug 935099 will track the landing on m-c.
When it lands on m-c a new comment will be added here as well with the m-c changeset.
This is being done so we can still use scrumbugs efficiently. 
See bug 935099 for further details.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 935099
Could anyone please give guidelines that can help the QA in verifying this issue? Thanks!
Flags: needinfo?(netzen)
You can verify that the same profile data is being used.
For any specific issues found please post new bugs, but if you find in general, yes they're using the same profiles then this is good.
Note that preferences is not shared.
Flags: needinfo?(netzen)
Passwords and history work alright. I'm having issues though with the bookmarks: it doesn't matter if I bookmark a page from desktop or metro mode, it doesn't appear as bookmarked in both. 

Do you have any suggestions/thoughts?  Thank you so much for your help, Brian! :)

Tested on Win 8 64-bit, for iteration #18, with latest oak build (build ID: 20131114040200).
Flags: needinfo?(netzen)
that means this is working, but please post about the bookmarks issue.
Flags: needinfo?(netzen)
(In reply to Brian R. Bondy [:bbondy] from comment #11)
> that means this is working, but please post about the bookmarks issue.

I've logged bug 939092 and CC'ed you there. Thanks!
Attachment #818637 - Attachment is obsolete: true
Attachment #8333973 - Flags: review+
Attachment #818673 - Attachment is obsolete: true
Attachment #818638 - Attachment is obsolete: true
Added author, bug description and reviewing in preparation for landing on m-c.
Attachment #8333973 - Attachment is obsolete: true
Attachment #8334619 - Flags: review+
Relanded on post-australis rebased oak:
https://hg.mozilla.org/projects/oak/rev/6840c38c5229
Verified as fixed on Win 8 64-bit, for iteration #19, with latest oak build (build ID: 20131127114543).

Passwords and history work alright. 

On the other hand, bookmarks don't work as mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=939092#c28 :

- if I bookmark a page in Desktop mode, it will appear in the "Firefox Touch" folder, but it doesn't appear in the Start Screen of the Metro mode, in the Bookmarks list

- viceversa works alright: when bookmarking a page from Metro mode, this will also appear as bookmarked in Desktop mode + will appear in the "Firefox Touch" folder
That's expected, see the bookmarks related bug in this iteration as well.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
https://hg.mozilla.org/integration/fx-team/rev/f5eea4f293d3
Target Milestone: --- → Firefox 28
https://hg.mozilla.org/mozilla-central/rev/f5eea4f293d3
Status: NEW → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Verified as fixed on Win 8 64-bit, for iteration #19, with latest Nightly, 2013-12-05. Passwords and history work alright.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.