924995 - Story - Use same base app name so that it uses the same profile and more

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P2)

Description

[Brian R. Bondy [:bbondy]]

We should use the same app base name when we share the same profile, so that it uses the same profile dir, and so that other things work as expected.

To do this we should set this:
http://dxr.mozilla.org/mozilla-central/source/browser/metro/metroapp.ini.in#l4

Because of this:
http://dxr.mozilla.org/mozilla-central/source/browser/confvars.sh#l6

We should just be able to do:
Name=@MOZ_APP_BASENAME@

p=1

Comment 1

[Brian R. Bondy [:bbondy]]

bbondy: so I think you need to add the define here: http://dxr.mozilla.org/mozilla-central/source/browser/metro/Makefile.in#l19

bbondy: the define would look like this: http://dxr.mozilla.org/mozilla-central/source/webapprt/Makefile.in#l31

Comment 2

[Marina Samuel [:emtwo]]

Attachment: Patch to share profile data

Comment 3

[Marina Samuel [:emtwo]]

Attachment: firefox.exe

Here's the build. This is pretty neat!

Comment 4

[Marina Samuel [:emtwo]]

Attachment: metroapp.ini.in

Brian pointed out.. that was my local build so if someone wants to try it, they'd need to swap their metroapp.ini.in with this one. I will post a proper build.

Comment 5

[Marina Samuel [:emtwo]]

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-c6b67e2a81b2/try-win32/firefox-27.0a1.en-US.win32.installer.exe

To try this, install in a different directory that doesn't already contain a Nightly because of bug 928432.

Comment 6

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/projects/oak/rev/14bcd0194c56

Comment 7

[Brian R. Bondy [:bbondy]]

Landed on oak here:
https://hg.mozilla.org/projects/oak/rev/14bcd0194c56

Bug 935099 will track the landing on m-c.
When it lands on m-c a new comment will be added here as well with the m-c changeset.
This is being done so we can still use scrumbugs efficiently. 
See bug 935099 for further details.

Comment 8

[Manuela Muntean [Away]]

Could anyone please give guidelines that can help the QA in verifying this issue? Thanks!

Comment 9

[Brian R. Bondy [:bbondy]]

You can verify that the same profile data is being used.
For any specific issues found please post new bugs, but if you find in general, yes they're using the same profiles then this is good.
Note that preferences is not shared.

Comment 10

[Manuela Muntean [Away]]

Passwords and history work alright. I'm having issues though with the bookmarks: it doesn't matter if I bookmark a page from desktop or metro mode, it doesn't appear as bookmarked in both. 

Do you have any suggestions/thoughts?  Thank you so much for your help, Brian! :)

Tested on Win 8 64-bit, for iteration #18, with latest oak build (build ID: 20131114040200).

Comment 11

[Brian R. Bondy [:bbondy]]

that means this is working, but please post about the bookmarks issue.

Comment 12

[Manuela Muntean [Away]]

(In reply to Brian R. Bondy [:bbondy] from comment #11)
> that means this is working, but please post about the bookmarks issue.

I've logged bug 939092 and CC'ed you there. Thanks!

Comment 13

[Marina Samuel [:emtwo]]

Attachment: Patch to share profile data (rebased on mc with Australis)

Comment 14

[Brian R. Bondy [:bbondy]]

Attachment: Patch to share profile data (rebased on mc with Australis)

Added author, bug description and reviewing in preparation for landing on m-c.

Comment 15

[Brian R. Bondy [:bbondy]]

Relanded on post-australis rebased oak:
https://hg.mozilla.org/projects/oak/rev/6840c38c5229

Comment 16

[Manuela Muntean [Away]]

Verified as fixed on Win 8 64-bit, for iteration #19, with latest oak build (build ID: 20131127114543).

Passwords and history work alright. 

On the other hand, bookmarks don't work as mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=939092#c28 :

- if I bookmark a page in Desktop mode, it will appear in the "Firefox Touch" folder, but it doesn't appear in the Start Screen of the Metro mode, in the Bookmarks list

- viceversa works alright: when bookmarking a page from Metro mode, this will also appear as bookmarked in Desktop mode + will appear in the "Firefox Touch" folder

Comment 17

[Brian R. Bondy [:bbondy]]

That's expected, see the bookmarks related bug in this iteration as well.

Comment 18

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/fx-team/rev/f5eea4f293d3

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f5eea4f293d3

Comment 20

[Manuela Muntean [Away]]

Verified as fixed on Win 8 64-bit, for iteration #19, with latest Nightly, 2013-12-05. Passwords and history work alright.