Closed Bug 925016 Opened 7 years ago Closed 7 years ago

always use method_exchangeImplementations when swizzling methods on OS X

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

Attached patch Fix v1.0Splinter Review
We should always use method_exchangeImplementations when swizzling methods on OS X, even on i386. It's safer and supported in 10.6+.
Attachment #814994 - Flags: review?(smichaud)
Comment on attachment 814994 [details] [diff] [review]
Fix v1.0

Looks fine to me.
Attachment #814994 - Flags: review?(smichaud) → review+
https://hg.mozilla.org/mozilla-central/rev/5dc3c476f55e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.