Closed Bug 925027 Opened 6 years ago Closed 6 years ago

stop using ancient Carbon scrap APIs in i386 OS X embedding

Categories

(Core Graveyard :: Embedding: Mac, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

Attached patch Fix v1.0Splinter Review
We use some old Carbon scrap APIs in i386 builds to manage find strings. We should stop using them, they're deprecated and it's extra code that nobody uses since we ship 64-bit by default and really don't want people using i386 builds anyway.

This code produces a deprecated API usage compiler warning.

What was this code actually for:

Mac OS X has a search clipboard, to sync find strings across applications. The code is attempting to use the string from the find clipboard as the search string, and when the user enters a new string it puts the new string on the find clipboard.
Attachment #815004 - Flags: review?(benjamin)
Attachment #815004 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/2cc13126ec74
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.