925083 - remove support/code for nsIAppleFileDecoder

Status: RESOLVED FIXED

Description

[Josh Aas]

Created attachment 815055 [details] [diff] [review]
Fix v1.0

We disabled nsIAppleFileDecoder a long time ago for x86_64, left it enabled for i386. We don't need to carry it around any more.

Comment 1

[Josh Aas]

diffstat: 7 files changed, 2 insertions(+), 625 deletions(-)

Comment 2

[Josh Aas]

Comment on attachment 815055 [details] [diff] [review]
Fix v1.0

Review of attachment 815055 [details] [diff] [review]:
-----------------------------------------------------------------

Requesting review from Patrick as he's the module owner.

Comment 3

[Josh Aas]

http://hg.mozilla.org/integration/mozilla-inbound/rev/266532efd5cb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/266532efd5cb

Comment 5

[Frank Wein [:mcsmurf]]

So I guess this code was removed for cleaning things up? It looks like Thunderbird still needs it for some (rather strange) Apple mail decoding thing (Bug 925083). But then that code never worked on 64-bit builds, it was just #ifdef-ed out in 2010 (as the file decoder never worked on 64 bit, Bug 519021). Maybe Thunderbird should copy this code into mailnews/ then somewhere.

Comment 6

[Frank Wein [:mcsmurf]]

I meant Bug 926195 in Comment 5.

Comment 7

[Mark Banner (:standard8)]

(In reply to Frank Wein [:mcsmurf] from comment #5)
> So I guess this code was removed for cleaning things up? It looks like
> Thunderbird still needs it for some (rather strange) Apple mail decoding
> thing (Bug 925083). But then that code never worked on 64-bit builds, it was
> just #ifdef-ed out in 2010 (as the file decoder never worked on 64 bit, Bug
> 519021). Maybe Thunderbird should copy this code into mailnews/ then
> somewhere.

Given we've not had any complaints about it since TB 5 was released with 64 bit support, and most newer macs are 64-bit compatible, I think we could probably just drop that code. It may break some instances, but it was never clear how much the special encoding format was used or not.