Closed Bug 925083 Opened 6 years ago Closed 6 years ago

remove support/code for nsIAppleFileDecoder

Categories

(Core :: Networking, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file)

Attached patch Fix v1.0Splinter Review
We disabled nsIAppleFileDecoder a long time ago for x86_64, left it enabled for i386. We don't need to carry it around any more.
diffstat: 7 files changed, 2 insertions(+), 625 deletions(-)
Comment on attachment 815055 [details] [diff] [review]
Fix v1.0

Review of attachment 815055 [details] [diff] [review]:
-----------------------------------------------------------------

Requesting review from Patrick as he's the module owner.
Attachment #815055 - Flags: review?(mcmanus)
Attachment #815055 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/266532efd5cb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Blocks: 926195
So I guess this code was removed for cleaning things up? It looks like Thunderbird still needs it for some (rather strange) Apple mail decoding thing (Bug 925083). But then that code never worked on 64-bit builds, it was just #ifdef-ed out in 2010 (as the file decoder never worked on 64 bit, Bug 519021). Maybe Thunderbird should copy this code into mailnews/ then somewhere.
(In reply to Frank Wein [:mcsmurf] from comment #5)
> So I guess this code was removed for cleaning things up? It looks like
> Thunderbird still needs it for some (rather strange) Apple mail decoding
> thing (Bug 925083). But then that code never worked on 64-bit builds, it was
> just #ifdef-ed out in 2010 (as the file decoder never worked on 64 bit, Bug
> 519021). Maybe Thunderbird should copy this code into mailnews/ then
> somewhere.

Given we've not had any complaints about it since TB 5 was released with 64 bit support, and most newer macs are 64-bit compatible, I think we could probably just drop that code. It may break some instances, but it was never clear how much the special encoding format was used or not.
You need to log in before you can comment on or make changes to this bug.