Closed Bug 925140 Opened 7 years ago Closed 7 years ago
Remove unnecessary ns
Algorithm .h includes from gfx/2d
Two chromium-derived .cpp files in gfx/2d/ have #includes for nsAlgorithm.h, for no apparent reason. (It might possibly be because we used to support VC9, which needed nsAlgorithm's "std::abs()" definition, but that's not relevant anymore because we don't support VC9 anymore, and I'm ripping out that abs() definition in bug 925129.) Anyway, we should drop this nsAlgorithm.h include, since it's not needed and it'll make for less xpcom headers and #defines influencing gfx/2d* which is a win (since it saves us from stuff like bug 924768).
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #815122 - Flags: review?(jmuizelaar)
Comment on attachment 815122 [details] [diff] [review] fix v1 Actually, looks like Jeff's on vacation. tn, looks like you've touched these files; mind reviewing?
Attachment #815122 - Flags: review?(jmuizelaar) → review?(tnikkel)
Attachment #815122 - Flags: review?(tnikkel) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.