Closed
Bug 925164
Opened 11 years ago
Closed 11 years ago
Lockscreen slider has wrong role and aria markup
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Unassigned)
References
Details
(Keywords: access)
Attachments
(1 file)
lockscreen-area-slide does not need a role of "button". And it does not need and (unlocalizable?) label.
|
Reporter | |
Comment 1•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/12766
|
|
Reporter | |
Comment 2•11 years ago
|
||
Pointer to Github pull-request
|
|
Reporter | |
Updated•11 years ago
|
Attachment #815150 -
Flags: review?(timdream)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 815150 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12766 Looks good but :snowmantw should confirm. Additionally, please remove the l10n string from en-US.properties if we remove the id.
Attachment #815150 -
Flags: review?(timdream)
Attachment #815150 -
Flags: review?(gweng)
Attachment #815150 -
Flags: feedback+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 815150 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12766 It works fine. And I think I must apologize that I implemented this version so hastily that there're so many details I missed. Beside this, I really should refactor it and completely solve the "glitch" problem with new approach of implementation with canvas or something else.
Attachment #815150 -
Flags: review?(gweng) → review+
|
|
Reporter | |
Comment 5•11 years ago
|
||
Thanks! https://github.com/mozilla-b2g/gaia/commit/f795c01cb9e4293ee8105979228d4000992d9337
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•