Closed Bug 925164 Opened 6 years ago Closed 6 years ago
Lockscreen slider has wrong role and aria markup
358 bytes, text/html
lockscreen-area-slide does not need a role of "button". And it does not need and (unlocalizable?) label.
Pointer to Github pull-request
Comment on attachment 815150 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12766 Looks good but :snowmantw should confirm. Additionally, please remove the l10n string from en-US.properties if we remove the id.
Comment on attachment 815150 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12766 It works fine. And I think I must apologize that I implemented this version so hastily that there're so many details I missed. Beside this, I really should refactor it and completely solve the "glitch" problem with new approach of implementation with canvas or something else.
Attachment #815150 - Flags: review?(gweng) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.