Closed Bug 925169 Opened 6 years ago Closed 6 years ago

get rid of MOZ_MEMORY_SIZEOF_PTR_2POW

Categories

(Core :: Memory Allocator, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: froydnj, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Some preprocessor magic can take care of this.
Preprocessor defines work just as well, though they are more vunerable to new
systems.  Between Windows and Unix, though, I think we are covered.
Attachment #815149 - Flags: review?(mh+mozilla)
The sole use has been eliminated, let's get rid of this.
Attachment #815151 - Flags: review?(mh+mozilla)
Comment on attachment 815149 [details] [diff] [review]
part 1 - don't use MOZ_MEMORY_SIZEOF_PTR_2POW in jemalloc.c

Review of attachment 815149 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/mozjemalloc/jemalloc.c
@@ +298,5 @@
>  typedef unsigned char uint8_t;
>  typedef unsigned uint32_t;
>  typedef unsigned long long uint64_t;
>  typedef unsigned long long uintmax_t;
> +#if defined(_WIN64) || defined(__LP64__)

You can remove __LP64__ here, since it's a windows-only section.
Attachment #815149 - Flags: review?(mh+mozilla) → review+
Attachment #815151 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/35816c397a14
https://hg.mozilla.org/mozilla-central/rev/6ae66f8f377b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.