925169 - get rid of MOZ_MEMORY_SIZEOF_PTR_2POW

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Nathan Froyd [:froydnj]]

Some preprocessor magic can take care of this.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - don't use MOZ_MEMORY_SIZEOF_PTR_2POW in jemalloc.c

Preprocessor defines work just as well, though they are more vunerable to new
systems.  Between Windows and Unix, though, I think we are covered.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - delete MOZ_MEMORY_SIZEOF_PTR_2POW from configury

The sole use has been eliminated, let's get rid of this.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 815149 [details] [diff] [review]
part 1 - don't use MOZ_MEMORY_SIZEOF_PTR_2POW in jemalloc.c

Review of attachment 815149 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/mozjemalloc/jemalloc.c
@@ +298,5 @@
>  typedef unsigned char uint8_t;
>  typedef unsigned uint32_t;
>  typedef unsigned long long uint64_t;
>  typedef unsigned long long uintmax_t;
> +#if defined(_WIN64) || defined(__LP64__)

You can remove __LP64__ here, since it's a windows-only section.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35816c397a14
https://hg.mozilla.org/mozilla-central/rev/6ae66f8f377b