925184 - [B2G][Settings] The user cannot export contacts to the memory card when USB Storage is enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: USBStorageExport.mp4

Description:
The user cannot export contacts to the memory card when USB Storage is enabled even though the phone is not plugged into the computer. The user has to turn USB Storage off in settings to export the contacts to the memory card.

Repro Steps:
1)  Updated Buri to Build ID: 20131009004001
2)  Tap on the "Settings" icon.
3)  Scroll down and enable USB Storage.
4)  Tap the "Home Button" on the phone and tap on the "Contacts" icon.
5)  Tap on the "Settings" icon in contacts.
6)  Tap on "Export Contacts".

Actual:
The "Memory card" is grayed out even though the phone is not plugged into the computer.

Expected:
The "Memory card" is not grayed out when the phone is not plugged into the computer with USB Storage enabled.

Environmental Variables
Device: Buri v 1.2.0 Mozilla RIL
Build ID: 20131009004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/e5edb484e2a9
Gaia: 672c47bf94b69a329e0aacb9228a6aa16ade6226
Platform Version: 26.0a2
RIL Version: 01.02.00.019.056 

Notes:
Repro frequency: 100%
See attached: video clip

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does not reproduce on Leo v 1.1.0 Mozilla Rill because the "Export Contact" functionality was not implemented on that version.

Environmental Variables
Device: Leo v 1.1.0 Mozilla COM RIL
Build ID: 20131001041206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/c630289d6388
Gaia: 02b975e6ce12922928c74276ac7d19432a03f126
Platform Version: 18.1
RIL Version: 01.01.00.019.240

Comment 2

[Preeti Raghunath(:Preeti)]

Tim

Please review for Settings.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is not a settings app bug according to comment 0.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

We will need to investigate if we can access the sdcard when no cable is connected.

So far we are checking for the settings preference, and even if the cable is not connected if it's setup, we just detect this setting and disable the button.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

it does not seem like Bug 911075 fixed this bug
triage: koi+ as the 911075 koi+ bug did not seem to fix this

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Joe Cheng [:jcheng] from comment #5)
> it does not seem like Bug 911075 fixed this bug
> triage: koi+ as the 911075 koi+ bug did not seem to fix this

I don't think bug 911075 will fix this bug, according to our original implementation, we are just looking for USB mass storage setting, not for the cable being plugged or unplugged.

Will try to have something ready soon.

Thanks!
F.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 12967

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Changed the approach to do this, now not listening to the setting, but just the sdcard change. Will be triggered if the setting is enabled and we plug the cable.

While the sdcard is being shared (used as mass storage when cable plug), we will disable the use of this functionalities.

Thanks
F.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Hi Jose,

just added the suggestions.

Thanks
F.

Comment 10

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/1d832634550de25526eaf93137940f9fd73a4c7f

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 1d832634550de25526eaf93137940f9fd73a4c7f to:
v1.2: bd6199bc5482122d4f5bcb2110f157e6d24d9185

Comment 12

[Shilpa Suresh]

This issue no longer reproduces on Buri v 1.2 11/07 build.

The "Memory card" is not grayed out when the phone is not plugged into the computer with USB Storage enabled.

Environmental Variables
Device: Buri v 1.2.0 Mozilla RIL
Build ID: 20131107004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/26f1e160e696
Gaia: 590eb598aacf1e2136b2b6aca5c3124557a365ca
Platform Version: 26.0
Firmware Version: US_20131104