domUtils.getCSSValuesForProperty() does not return "unset" in autocomplete values

RESOLVED FIXED in mozilla27

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: miker, Assigned: heycam)

Tracking

(Blocks: 1 bug)

unspecified
mozilla27
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

getCSSValuesForProperty() fails to return "unset" in autocomplete values.

const DOMUtils = Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils);
DOMUtils.getCSSValuesForProperty("color").indexOf("unset"); // returns -1
Er, yes, we needed to add "unset" to http://hg.mozilla.org/mozilla-central/file/a141e39bf6da/layout/inspector/src/inDOMUtils.cpp#l595

I hate this duplication stuff.  :(
Ah, right.  Lucky we don't add CSS-wide keywords very often.
Assignee: nobody → cam
Comment on attachment 815189 [details] [diff] [review]
patch

r=me especially if you fix the tests?
Attachment #815189 - Flags: review?(bzbarsky) → review+
Depends on: 925218
(In reply to Boris Zbarsky [:bz] (Vacation Oct 12 - Oct 27) from comment #4)
> r=me especially if you fix the tests?

Yes that would help wouldn't it.  I'll update layout/inspector/tests/test_bug877690.html before landing.
https://hg.mozilla.org/mozilla-central/rev/4dad2edca27e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Blocks: 1254949
You need to log in before you can comment on or make changes to this bug.