925195 - ImageBridgeParent.cpp:201:30: warning: comparison of integers of different signs [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, minor)

Description

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

9:53.41 /home/keeler/mozilla-central/gfx/layers/ipc/ImageBridgeParent.cpp:201:30: warning: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'int' [-Wsign-compare]
 9:53.41     if (aFds[i].protocolId() == (int)GetProtocolId()) {

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: fix-warning.patch

The ImageBridgeParent::CloneToplevel() function cast GetProtocolId()'s IPCMessageStart enum return value to int, but compared it to an uint32_t.

Other uses of GetProtocolId() cast its return value to (just) `unsigned`:

https://mxr.mozilla.org/mozilla-central/search?string=%29getProtocolId%28%29

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 818831 [details] [diff] [review]
fix-warning.patch

Review of attachment 818831 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks!

::: gfx/layers/ipc/ImageBridgeParent.cpp
@@ +194,5 @@
>                                   base::ProcessHandle aPeerProcess,
>                                   mozilla::ipc::ProtocolCloneContext* aCtx)
>  {
>    for (unsigned int i = 0; i < aFds.Length(); i++) {
> +    if (aFds[i].protocolId() == (unsigned)GetProtocolId()) {

Can you use C++-style constructor here? E.g.: | == unsigned(GetProtocolId())|

Comment 3

[Chris Peterson [:cpeterson]]

Landed on mozilla-inbound with the changes suggested in comment 2:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fec466b50c14

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/fec466b50c14