Closed Bug 925197 Opened 11 years ago Closed 10 years ago

processor fails to ack to RabbitMQ if crash_id not found

Categories

(Socorro :: Backend, task)

Product:
Socorro
Component:
Backend
Platform:
x86_64
Linux
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: lars, Assigned: lars)

Details

execution of the `transform` method of the processor_app.py by-passes the `finished` function call if the crash_id is not found.  this means that rabbit keeps the crash forever thinking it has never been processed. 

solution: 

the function should be enclosed in a try-finally block so that all exits from that function result in a call to the `finished` function.  That'll make RabbitMQ much happier.
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ef898e4d928b04f8058915b5a6ffb014ca96b7c3
Merge pull request #1573 from twobraids/bug925197-ack-crash

fixes bug 925197 - ensured that jobs are ack'd even if the jobs fail
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.