processor fails to ack to RabbitMQ if crash_id not found

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lars, Assigned: lars)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

5 years ago
execution of the `transform` method of the processor_app.py by-passes the `finished` function call if the crash_id is not found.  this means that rabbit keeps the crash forever thinking it has never been processed. 

solution: 

the function should be enclosed in a try-finally block so that all exits from that function result in a call to the `finished` function.  That'll make RabbitMQ much happier.

Comment 1

5 years ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ef898e4d928b04f8058915b5a6ffb014ca96b7c3
Merge pull request #1573 from twobraids/bug925197-ack-crash

fixes bug 925197 - ensured that jobs are ack'd even if the jobs fail
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.