925226 - Bogus downcast in signaling_unittest

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Eric Rescorla (:ekr)]

Attachment: Fix

CloseSendStreams() assumes that the target stream is a Fake_AudioSourceStream() but this is not always so if you make a Fake_DOMMediaStream() with no base stream. This can cause crashes in the tests, esp. under ASan

Comment 1

[Eric Rescorla (:ekr)]

Comment on attachment 815218 [details] [diff] [review]
Fix

Review of attachment 815218 [details] [diff] [review]:
-----------------------------------------------------------------

r+ from abr over IRC.

Comment 2

[Eric Rescorla (:ekr)]

Comment on attachment 815218 [details] [diff] [review]
Fix

Review of attachment 815218 [details] [diff] [review]:
-----------------------------------------------------------------

r+ from abr over IRC.

Comment 3

[Eric Rescorla (:ekr)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3cca295fd212

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cca295fd212

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 815218 [details] [diff] [review]
Fix

Please just use checkin-needed unless there are multiple patches landing at different times.