Closed
Bug 925226
Opened 12 years ago
Closed 12 years ago
Bogus downcast in signaling_unittest
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: ekr, Assigned: ekr)
Details
Attachments
(1 file)
|
2.64 KB,
patch
|
ekr
:
review+
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
CloseSendStreams() assumes that the target stream is a Fake_AudioSourceStream() but this is not always so if you make a Fake_DOMMediaStream() with no base stream. This can cause crashes in the tests, esp. under ASan
|
Assignee | |
Comment 1•12 years ago
|
||
Comment on attachment 815218 [details] [diff] [review]
Fix
Review of attachment 815218 [details] [diff] [review]:
-----------------------------------------------------------------
r+ from abr over IRC.
Attachment #815218 -
Flags: review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 815218 [details] [diff] [review]
Fix
Review of attachment 815218 [details] [diff] [review]:
-----------------------------------------------------------------
r+ from abr over IRC.
Attachment #815218 -
Flags: checkin?
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Comment 5•12 years ago
|
||
Comment on attachment 815218 [details] [diff] [review]
Fix
Please just use checkin-needed unless there are multiple patches landing at different times.
Attachment #815218 -
Flags: checkin? → checkin+
|
|
||
Updated•12 years ago
|
Assignee: nobody → ekr
You need to log in
before you can comment on or make changes to this bug.
Description
•