Race condition with buildlist.py

RESOLVED FIXED in mozilla27

Status

RESOLVED FIXED
5 years ago
10 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla27
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
This is a build failure i got on the birch branch with pseudo derecurse enabled:
https://tbpl.mozilla.org/php/getParsedLog.php?id=28904665&tree=Birch

Looking at e.g. httpd.manifest that is only on one hand and not the other, the log does contain both buildlist.py commands for it, so somehow, this must be overwritten by another buildlist.py command...

My guess is that comes from some of the parallel dirs during the libs tier. It probably didn't happen before because libs was doing so much. With pseudo derecurse, libs doesn't do compilation, so there's more chances of existing race conditions being triggered.
(Assignee)

Comment 1

5 years ago
Created attachment 815239 [details] [diff] [review]
Don't parallelize the libs tier because of the race conditions it shows now it doesn't compile

I think this is the safest thing to do considering we don't know what kind of other races there can be. The more we move stuff to moz.build and out of the libs tier, the better it will get anyways.
Attachment #815239 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Different error on the same changeset in https://tbpl.mozilla.org/php/getParsedLog.php?id=28915264&tree=Birch :
Error: /builds/slave/bir-osx64-00000000000000000000/build/obj-firefox/i386/browser/installer/package-manifest:413: File missing in /builds/slave/bir-osx64-00000000000000000000/build/obj-firefox/i386/../x86_64/dist: FirefoxNightly.app/Contents/MacOS/chrome/toolkit/content/global/url-classifier/unittests.xul

This might require to do the same to the tools tier.
(Assignee)

Comment 4

5 years ago
But it doesn't entirely fix osx :(
(Assignee)

Comment 5

5 years ago
(In reply to Mike Hommey [:glandium] from comment #4)
> But it doesn't entirely fix osx :(

And that's probably because httpd.manifest is done in tools.
(Assignee)

Comment 6

5 years ago
(In reply to Mike Hommey [:glandium] from comment #5)
> (In reply to Mike Hommey [:glandium] from comment #4)
> > But it doesn't entirely fix osx :(
> 
> And that's probably because httpd.manifest is done in tools.

FTR, https://tbpl.mozilla.org/php/getParsedLog.php?id=28919823&tree=Birch
(Assignee)

Comment 7

5 years ago
Created attachment 815270 [details] [diff] [review]
Don't parallelize the libs tier because of the race conditions it shows now it doesn't compile

https://tbpl.mozilla.org/?tree=Birch&rev=08da2afdaeeb
Attachment #815270 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Attachment #815239 - Attachment is obsolete: true
Attachment #815239 - Flags: review?(gps)
(Assignee)

Comment 8

5 years ago
(In reply to Mike Hommey [:glandium] from comment #7)
> https://tbpl.mozilla.org/?tree=Birch&rev=08da2afdaeeb

The osx tests redness is due to our setup not handling multiple rebuilds properly.
Attachment #815270 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/adcb20866454
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27

Updated

10 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.