Closed Bug 925236 Opened 6 years ago Closed 6 years ago

Race condition with buildlist.py

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file, 1 obsolete file)

This is a build failure i got on the birch branch with pseudo derecurse enabled:
https://tbpl.mozilla.org/php/getParsedLog.php?id=28904665&tree=Birch

Looking at e.g. httpd.manifest that is only on one hand and not the other, the log does contain both buildlist.py commands for it, so somehow, this must be overwritten by another buildlist.py command...

My guess is that comes from some of the parallel dirs during the libs tier. It probably didn't happen before because libs was doing so much. With pseudo derecurse, libs doesn't do compilation, so there's more chances of existing race conditions being triggered.
I think this is the safest thing to do considering we don't know what kind of other races there can be. The more we move stuff to moz.build and out of the libs tier, the better it will get anyways.
Attachment #815239 - Flags: review?(gps)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Different error on the same changeset in https://tbpl.mozilla.org/php/getParsedLog.php?id=28915264&tree=Birch :
Error: /builds/slave/bir-osx64-00000000000000000000/build/obj-firefox/i386/browser/installer/package-manifest:413: File missing in /builds/slave/bir-osx64-00000000000000000000/build/obj-firefox/i386/../x86_64/dist: FirefoxNightly.app/Contents/MacOS/chrome/toolkit/content/global/url-classifier/unittests.xul

This might require to do the same to the tools tier.
But it doesn't entirely fix osx :(
(In reply to Mike Hommey [:glandium] from comment #4)
> But it doesn't entirely fix osx :(

And that's probably because httpd.manifest is done in tools.
(In reply to Mike Hommey [:glandium] from comment #5)
> (In reply to Mike Hommey [:glandium] from comment #4)
> > But it doesn't entirely fix osx :(
> 
> And that's probably because httpd.manifest is done in tools.

FTR, https://tbpl.mozilla.org/php/getParsedLog.php?id=28919823&tree=Birch
Attachment #815239 - Attachment is obsolete: true
Attachment #815239 - Flags: review?(gps)
(In reply to Mike Hommey [:glandium] from comment #7)
> https://tbpl.mozilla.org/?tree=Birch&rev=08da2afdaeeb

The osx tests redness is due to our setup not handling multiple rebuilds properly.
Attachment #815270 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/adcb20866454
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.