925288 - Please enhance strings in generated list pages avoiding composite strings

Status: RESOLVED INCOMPLETE

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[Sandro Della Giustina]

I have already asked in l10nweb. This kind of pages:
https://addons.mozilla.org/it/firefox/themes/?sort=rating

it have a composite string in page title (Più votati temi) that is not localizable as single string. 
Unfortunately, in italian, it sounds really nasty, it seems a non  human translation. 

If possible, make these strings available without joining other strings, or at least supply a composite rule pattern to reverse the composition order.

Comment 1

[Francesco Lodolo [:flod]]

A possible easy way out could be to change the title structure to
Themes :: Top Rated :: Mozilla Add-ons

I guess every single locale is affected by this problem (checked fr and es-ES).

Comment 2

[:gerard-majax]

Clearly, it's nasty in french too ...

Comment 3

[Matt Basta [:basta]]

Is this bug specific to page titles? If so, please update the bug title.

Comment 4

[Sandro Della Giustina]

No, the string is used three times in the page: in title:
<title>      Più votati temi :: Componenti aggiuntivi per Firefox</title>
<li>Più votati temi</li>
<h2>Più votati temi</h2>

the most strikin is the header 2.

Comment 5

[Wil Clouser [:clouserw]]

To fix this:

Change title to:
> Themes :: Top Rated :: Mozilla Add-ons

Change <li> to:
> Top Rated

Change <h2> to:
> Top Rated

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/e6b7358ee649cb64264154f95c4bcc7c6f9e71be

Thanks!

Comment 7

[krupa raj[:krupa]]

With this change, 

<title>Featured Collections :: Add-ons for Firefox</title>

becomes

<title>Collection :: Featured :: Add-ons for Firefox </title>

Which seems more clunky to me. Can we fix that? Thanks!

Comment 8

[krupa raj[:krupa]]

More examples:

<title>Themes :: Add-ons for Firefox </title> 

becomes

<title>Themes :: Themes :: Add-ons for Firefox</title>


<title> Featured Extensions :: Add-ons for Firefox </title>

becomes

<title>  Extensions :: Featured :: Add-ons for Firefox </title>

Comment 9

[Christopher Van Wiemeersch [:cvan]]

Krupa, I agree with you on this. But comment 5 for example seems to suggest that that's what we're going for. I'm no L10n guru, but I think it reads better the original way.

Reverted until we have consensus here:

https://github.com/mozilla/zamboni/commit/ae83658

Comment 10

[Wil Clouser [:clouserw]]

What URL says Themes :: Themes :: Add-ons for Firefox?

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Wil Clouser [:clouserw] from comment #10)
> What URL says Themes :: Themes :: Add-ons for Firefox?

https://addons-dev.allizom.org/en-US/firefox/themes/ did, before this change was reverted.

> assert first == second, msg
E AssertionError: Expected page title: Themes :: Add-ons for Firefox. Actual page title: Themes :: Themes :: Add-ons for Firefox

Comment 12

[Wil Clouser [:clouserw]]

I would expect that to just say "Themes :: Add-ons for Firefox", yeah