Closed Bug 925326 Opened 6 years ago Closed 4 years ago

move addition of -Wno-uninitialized in bindings test Makefile to be effective

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: froydnj, Unassigned)

References

Details

Attachments

(1 file)

No description provided.
At some point, rules.mk started modifying CXXFLAGS.  The modification of CXXFLAGS,
then, needs to be moved after the inclusion of rules.mk.  The main bindings
Makefile already had this done.
Attachment #815344 - Flags: review?(Ms2ger)
Attachment #815344 - Flags: review?(Ms2ger) → review?(gps)
Comment on attachment 815344 [details] [diff] [review]
move addition of -Wno-uninitialized in bindings test Makefile to be effective

Review of attachment 815344 [details] [diff] [review]:
-----------------------------------------------------------------

Umm, no. CXXFLAGS should be modified *before* rules.mk. This patch probably works out of sheer luck. Perhaps you need to re-add config.mk to this Makefile.in?
Attachment #815344 - Flags: review?(gps)
(In reply to Gregory Szorc [:gps] from comment #2)
> Umm, no. CXXFLAGS should be modified *before* rules.mk. This patch probably
> works out of sheer luck. Perhaps you need to re-add config.mk to this
> Makefile.in?

Ah, I see, rules.mk includes config.mk if it's not already included.  Maybe we should just make rules.mk complain in such cases, and make whatever magic generates topsrcdir and the like include config.mk too?

I'll fixup the patch.
This change is no longer necessary because the tree is now -Wuninitialized clean (bug 1001975), including dom/bindings. I am removing these -Wno-uninitialized CXXFLAGS in bug 1240592.
Status: NEW → RESOLVED
Closed: 4 years ago
Depends on: 1240592
Resolution: --- → WONTFIX
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.