Closed
Bug 925422
Opened 11 years ago
Closed 11 years ago
[npm-mirror] Install devDependencies in addition to dependencies
Categories
(Testing Graveyard :: JSMarionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gaye, Assigned: gaye)
References
Details
Attachments
(2 files)
Right now our mirroring utility only grabs dependencies from manifests. It should also grab devDependencies since we use these in gaia.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gaye
|
|
Assignee | |
Comment 1•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment #815505 -
Flags: review?(jlal)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 815505 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/npm-mirror/pull/3
to make this work for all cases we should also handle peerDependancies (and do some refactoring)
Attachment #815505 -
Flags: review?(jlal) → review-
|
|
Assignee | |
Comment 3•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 815534 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/npm-mirror/pull/3
Thanks for the initial comments. I've gone ahead and moved manifest dependency finding out into its own module (deps.js) and added support for peer dependencies :)
Attachment #815534 -
Flags: review?(jlal)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 815505 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/npm-mirror/pull/3
I still have some trouble running this but I will address that in a followup bug.
Attachment #815505 -
Flags: review- → review+
|
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Updated•10 years ago
|
Attachment #815534 -
Flags: review?(jlal)
|
||
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•