925473 - sftp (gio/gvfs) doesn't work, may crash

Status: RESOLVED WORKSFORME

(Core :: Networking, defect, P3)

Description

[Daniel Veditz [:dveditz]]

Kurt Roeckx reports that using sftp: will crash both Iceweasel and a Mozilla-built Firefox 24 release on his Debian system.

e.g. sftp://ftp.debian.org/

The crash is a null-deref
bp-7bc25345-a3f9-4bc6-a4c0-a81832131010

We tried it locally on a Gentoo system and it didn't crash, but it also didn't do anything -- just a blank tab. A debug build spit out the message

** (firefox:28841): WARNING **: Mount failed: Login dialog cancelled 14

Comment 1

[Mike Hommey [:glandium]]

The crashing line is:
    while (*uri_schemes != nullptr) {

which suggests uri_schemes is NULL.
It is assigned with:

    const gchar* const * uri_schemes = g_vfs_get_supported_uri_schemes(gvfs);

Comment 2

[Karl Tomlinson (:karlt)]

Here, there is always a

WARNING: NS_ENSURE_TRUE(resultIndex >= 0) failed: file /home/karl/moz/dev/toolkit/components/autocomplete/nsAutoCompleteController.cpp, line 1470

before

** (firefox:5381): WARNING **: Mount failed: Login dialog cancelled 14

> bp-7bc25345-a3f9-4bc6-a4c0-a81832131010

http://hg.mozilla.org/releases/mozilla-release/annotate/7c3b0732e765/extensions/gio/nsGIOProtocolHandler.cpp#l1016

Looks like g_vfs_get_supported_uri_schemes(gvfs) has returned null.
That would be a bug in GVfs because that function should return "a NULL-terminated array of strings."

Comment 3

[Karl Tomlinson (:karlt)]

Loading sftp://ftp.debian.org/ from about:newtab is a bit like Bug 702432.

When loading other sites, the previous url is restored.

Those may not be bugs in the nsGIOProtocolHandler.

Comment 4

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 5

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.