Add OpenGraph metadata to valet details pages

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jon, Assigned: jon)

Tracking

Details

(Whiteboard: mozfest)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
When the valet started to generate detail pages we did not add functionality for generating opengraph tags. This should be rectified by adding tags for og:url, og:updated_time, and og:site_name.
I just had a report of this actually.

We also don't give any thumbnail info - we should!  As well as decription etc that we used to give.
Whiteboard: mozfest
(Assignee)

Comment 2

5 years ago
Created attachment 817369 [details] [review]
https://github.com/mozilla/make-valet/pull/24

Not too sure what to do, if anything, when there is no data available... I guess just keeping it empty is fine?
Attachment #817369 - Flags: review?(cade)

Updated

5 years ago
Attachment #817369 - Flags: review?(cade) → review+

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.