Closed
Bug 925482
Opened 11 years ago
Closed 11 years ago
Add OpenGraph metadata to valet details pages
Categories
(Webmaker Graveyard :: Make Valet, defect)
Webmaker Graveyard
Make Valet
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: jon)
References
Details
(Whiteboard: mozfest)
Attachments
(1 file)
When the valet started to generate detail pages we did not add functionality for generating opengraph tags. This should be rectified by adding tags for og:url, og:updated_time, and og:site_name.
|
||
Comment 1•11 years ago
|
||
I just had a report of this actually. We also don't give any thumbnail info - we should! As well as decription etc that we used to give.
Whiteboard: mozfest
|
Assignee | |
Comment 2•11 years ago
|
||
Not too sure what to do, if anything, when there is no data available... I guess just keeping it empty is fine?
Attachment #817369 -
Flags: review?(cade)
|
||
Updated•11 years ago
|
Attachment #817369 -
Flags: review?(cade) → review+
|
||
Comment 3•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/make-valet https://github.com/mozilla/make-valet/commit/734cc21309884d6df77d5565eee3cfe10745d915 Fix bug 925482 - Add OpenGraph meta tags
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•