925495 - Speed up nodeName and localName bindings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We can use DOMString for these, which should help a lot in the cache-hit case.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Move DOMString out to a separate header.

Let me know if you'd prefer that I try to preserve blame via hg cp here

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Make the localName and nodeName bindings use DOMString, for extra speed.

Comment 3

[Boris Zbarsky [:bzbarsky]]

   https://hg.mozilla.org/integration/mozilla-inbound/rev/6114164c3d1b
   https://hg.mozilla.org/integration/mozilla-inbound/rev/46029c9fbfe4

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for OSX (at least) crashes.
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdb83f77bdb3

https://tbpl.mozilla.org/php/getParsedLog.php?id=28993302&tree=Mozilla-Inbound

Comment 5

[Ryan VanderMeulen [:RyanVM]]

And mochitest failures.
https://tbpl.mozilla.org/php/getParsedLog.php?id=28995077&tree=Mozilla-Inbound

Comment 6

[Boris Zbarsky [:bzbarsky]]

Gah.  Sounds like localName is nullable, and hence might not have a stringbuffer.  Need to check for the null case.

Comment 7

[Boris Zbarsky [:bzbarsky]]

With that fixed:

   https://hg.mozilla.org/integration/mozilla-inbound/rev/5397cf44cbca
   https://hg.mozilla.org/integration/mozilla-inbound/rev/348066ccaa45

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5397cf44cbca
https://hg.mozilla.org/mozilla-central/rev/348066ccaa45