925531 - Get rid of nativeOwnership = worker for URL

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 815601 [details] [diff] [review]
Patch

Review of attachment 815601 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with these fixed:

::: dom/workers/URL.cpp
@@ +557,5 @@
>      return nullptr;
>    }
>  
> +  nsAutoPtr<URL> url = new URL(workerPrivate, proxy);
> +  return url.forget();

No need for this nsAutoPtr...

@@ +582,5 @@
>      return nullptr;
>    }
>  
> +  nsAutoPtr<URL> url = new URL(workerPrivate, proxy);
> +  return url.forget();

Or this one.

@@ +603,5 @@
>        NS_ERROR("Failed to dispatch teardown runnable!");
>      }
>    }
> +
> +  MOZ_COUNT_DTOR(workers::URL);

Nit: Put this at the top of the function in case someone ever adds a return or something

::: dom/workers/URL.h
@@ +14,5 @@
> +#include "mozilla/dom/NonRefcountedDOMObject.h"
> +
> +namespace mozilla {
> +namespace dom {
> +struct objectURLOptions;

What's this for?

@@ +29,5 @@
>  
>    URL(WorkerPrivate* aWorkerPrivate, URLProxy* aURLProxy);
>    ~URL();
>  
> +  nsISupports* GetParentObject() const {

Nit: return type and { on their own lines, for WrapObject too

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/092df4b7af99

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/092df4b7af99