Closed Bug 925531 Opened 6 years ago Closed 6 years ago

Get rid of nativeOwnership = worker for URL

Categories

(Core :: DOM: Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: khuey, Assigned: khuey)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch PatchSplinter Review
Attachment #815601 - Flags: review?(bent.mozilla)
Comment on attachment 815601 [details] [diff] [review]
Patch

Review of attachment 815601 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with these fixed:

::: dom/workers/URL.cpp
@@ +557,5 @@
>      return nullptr;
>    }
>  
> +  nsAutoPtr<URL> url = new URL(workerPrivate, proxy);
> +  return url.forget();

No need for this nsAutoPtr...

@@ +582,5 @@
>      return nullptr;
>    }
>  
> +  nsAutoPtr<URL> url = new URL(workerPrivate, proxy);
> +  return url.forget();

Or this one.

@@ +603,5 @@
>        NS_ERROR("Failed to dispatch teardown runnable!");
>      }
>    }
> +
> +  MOZ_COUNT_DTOR(workers::URL);

Nit: Put this at the top of the function in case someone ever adds a return or something

::: dom/workers/URL.h
@@ +14,5 @@
> +#include "mozilla/dom/NonRefcountedDOMObject.h"
> +
> +namespace mozilla {
> +namespace dom {
> +struct objectURLOptions;

What's this for?

@@ +29,5 @@
>  
>    URL(WorkerPrivate* aWorkerPrivate, URLProxy* aURLProxy);
>    ~URL();
>  
> +  nsISupports* GetParentObject() const {

Nit: return type and { on their own lines, for WrapObject too
Attachment #815601 - Flags: review?(bent.mozilla) → review+
Blocks: SyncIDB
https://hg.mozilla.org/mozilla-central/rev/092df4b7af99
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.