Closed
Bug 925584
Opened 11 years ago
Closed 11 years ago
Remove some unnecessary jsapi.h inclusions from .cpp files.
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
42.78 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
This patch reduces the number of files rebuilt after touching jsapi.h from 875 to 865. I did the ones in js/src/ with IWYU and the rest by looking through the code for "JS" and "js" strings to see if anything from jsapi.h was used.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #815652 -
Flags: review?(Ms2ger)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 815652 [details] [diff] [review] Remove some unnecessary jsapi.h inclusions from .cpp files. Review of attachment 815652 [details] [diff] [review]: ----------------------------------------------------------------- Seems fine if it builds. Sorry for the delay.
Attachment #815652 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d31a31002287
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d31a31002287
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Target Milestone: mozilla28 → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•