Closed Bug 925588 Opened 11 years ago Closed 9 years ago

Intermittent TEST-UNEXPECTED-FAIL | test_property_syntax_errors.html | Test timed out.

Categories

(Core :: Layout, defect, P5)

Product:
Core
Component:
Layout
Platform:
x86_64
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: KWierso, Assigned: jfkthame)

Details

(Keywords: intermittent-failure)

Attachments

(3 files)

index.png
1.32 MB, image/png
Details
Work around timeout issue for long-running silent mochitest
1.33 KB, patch
dholbert
: review-
Details | Diff | Splinter Review
Extend timeout for test_property_syntax_errors.html, as it frequently takes over 5 minutes on b2g emulator
1.03 KB, patch
Details | Diff | Splinter Review
Attached image index.png — 
https://tbpl.mozilla.org/php/getParsedLog.php?id=28952544&tree=Mozilla-Inbound
using slave: talos-mtnlion-r5-086


14:53:49     INFO -  42471 INFO TEST-PASS | /tests/layout/style/test/test_property_database.html | must have non-initial values for property 'image-orientation'
14:53:49     INFO -  42472 INFO TEST-PASS | /tests/layout/style/test/test_property_database.html | longhand property '-moz-osx-font-smoothing' must not have subproperty list
14:53:49     INFO -  42473 INFO TEST-PASS | /tests/layout/style/test/test_property_database.html | must have initial values for property '-moz-osx-font-smoothing'
14:53:49     INFO -  42474 INFO TEST-PASS | /tests/layout/style/test/test_property_database.html | must have non-initial values for property '-moz-osx-font-smoothing'
14:53:49     INFO -  42475 INFO TEST-END | /tests/layout/style/test/test_property_database.html | finished in 297ms
14:53:49     INFO -  42476 INFO TEST-START | /tests/layout/style/test/test_property_syntax_errors.html
14:56:24     INFO -  NOTE: child process received `Goodbye', closing down
14:58:49     INFO -  libpng warning: zero length keyword
14:58:49     INFO -  libpng warning: Empty language field in iTXt chunk
14:58:52     INFO -  SCREENSHOT: [SEE ATTACHMENT]
14:58:52     INFO -  42477 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/style/test/test_property_syntax_errors.html | Test timed out.
14:58:52     INFO -  42478 INFO TEST-END | /tests/layout/style/test/test_property_syntax_errors.html | finished in 301244ms
14:58:52     INFO -  42479 INFO TEST-START | /tests/layout/style/test/test_redundant_font_download.html
14:58:52     INFO -  42480 INFO TEST-PASS | /tests/layout/style/test/test_redundant_font_download.html | request log has been initialized
14:58:52     INFO -  42481 INFO TEST-PASS | /tests/layout/style/test/test_redundant_font_download.html | server received font request
Priority: -- → P5
This is an example of the issue described in bug 1187038. In the absence of a better solution for the time being, I suggest we do something like this to work around the problem; and assuming it stops the oranges -- currently running at about 50% for B2G-emulator-opt-M9 on inbound -- we could do the same to the other style-system tests that suffer from the same problem.
Attachment #8685920 - Flags: review?(dholbert)
Are you sure this is the right type of problem for that fix?

Bug 1187038 is specifically about spurious "timed out after 1000 seconds of no output" failures; whereas this bug seems to be plain old "Test timed out".  (without any mention of 'no output')

For "Test timed out" [while the test is still doing useful work], I think the only fix is requestLongerTimeout(), and "dump" wouldn't help.
Flags: needinfo?(jfkthame)
For example, the top log in comment 24 is:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=17046755
 19:01:57     INFO -  627 INFO TEST-START | layout/style/test/test_property_syntax_errors.html
 19:07:06     INFO -  628 INFO TEST-OK | layout/style/test/test_property_syntax_errors.html | took 309150ms
 19:07:10     INFO -  629 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | Test timed out.


I believe 300,000ms (5 minutes) is the default timeout, and we're exceeding that here. So, I'd expect we need requestLongerTimeout.
Given that the failure actually consists of three lines,

11:06:09 INFO - 627 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | Test timed out.
11:06:09 INFO - 628 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_property_syntax_errors.html | Test timed out. - Result logged after SimpleTest.finish()

and then eventually

Output exceeded 52428800 bytes, remaining output has been truncated (output was 52429256 bytes)

I'd be really surprised if adding spew would result in having a good time.
Comment on attachment 8685920 [details] [diff] [review]
Work around timeout issue for long-running silent mochitest

r- since I don't think this helps.

r=me on a patch that adds...
  SimpleTest.requestLongerTimeout(2);
right before the waitForExplicitFinish() call, though, if my comment 27 seems to be correct & we're just going over the 300-second threshold.
Attachment #8685920 - Flags: review?(dholbert) → review-
You're quite right, of course -- sorry, I was getting timeouts mixed up. Tryserver confirms that this lets emulator-opt-M9 stay consistently green even when test_property_syntax_errors takes well over 5 minutes (e.g. it's 374339ms in the final run on https://treeherder.mozilla.org/#/jobs?repo=try&revision=072f252a707a). Considering this pre-emptively r+'d, as it's exactly the patch you suggested in comment 29.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5a38550eaf46de5604cd541f88a6620b910e314
Bug 925588 - Extend timeout for test_property_syntax_errors.html, as it frequently takes over 5 minutes on b2g emulator. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/b5a38550eaf4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Flags: needinfo?(jfkthame)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: