925602 - [B2G][Contacts] No error message is given when a loss of data connection occurs while importing Gmail contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: LossofconnectionImportingContacts.txt

Description:
There is not an error message prompted to the user when a loss of data connection occurs while importing Gmail contacts.

Repro Steps:
1)  Updated Buri to Build ID: 20131010004001
2)  Tap on the "Contacts" icon.
3)  Tap on the "Settings" icon in contacts.
4)  Tap on "Import Contacts".
5)  Tap on "Gmail".
6)  Log into The Gmail account.
7)  Tap on "Select All" and tap on "Update".
8)  While the contacts are being imported, pull down the notification bar and turn off the data connection. If WiFi is connected turn it off too.

Actual:
The user is not presented with an error message when a loss of connection occurs when importing Gmail contacts. The user remains on the "Importing friends to contacts screen".

Expected:
The user is presented with the an error message and has the option to cancel the import or try again if their data connection comes back on.

Environmental Variables
Device: Buri v 1.2.0 Mozilla RIL
Build ID: 20131010004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/3f16dc100b1f
Gaia: 51f3c79ea93bb91d3b12e50b49d203a049a94a9b
Platform Version: 26.0a2

Notes:
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/7047/
See attached: logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does not occur on Leo v 1.1.0 COM RIL

Environmental Variables
Device: Leo v 1.1.0 COM RIL 
Build ID: 20131001041206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/c630289d6388
Gaia: 02b975e6ce12922928c74276ac7d19432a03f126
Platform Version: 18.1
RIL Version: 01.01.00.019.240

The user is presented with the message "Do you want to continue importing contacts without photos?" when they loose their data connection while importing contacts.

Comment 2

[Jose Manuel Cantera]

this one more regression from our beloved DOM LazyLoad and this is the 9th.

Comment 3

[Jose Manuel Cantera]

Attachment: 12788.html

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 815753 [details]
12788.html

Good job, thanks

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

triage: koi+ regression
jmcf, can you please land this? thanks

Comment 6

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/08f2d40e1b6392fdf80baaeb39b0a939708ab881

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 08f2d40e1b6392fdf80baaeb39b0a939708ab881 to:
v1.2: 90b3b63ce7f0ddf183de1565c11573325ddbd494

Comment 8

[Shilpa Suresh]

This issue no longer occurs on Buri v 1.3 master and v 1.2 aurora 10/17 build

The user is presented with the an error message and has the option to cancel the import of contacts or continue anyway.


10/17 v 1.3 master 

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20131017040202
Gecko: http://hg.mozilla.org/mozilla-central/rev/423b9c30c73d
Gaia: 616e87af0133496620aea89f21ca5d37acedf466
Platform Version: 27.0a1
Firmware Version: US_20130912_QC211

10/17 v 1.2 aurora

Environmental Variables
Device: Buri v 1.2.0 Mozilla RIL
Build ID: 20131017004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/7ca5d1e81d37
Gaia: dbcc171eae6b4d9d168a48291d5ea54c7580561a
Platform Version: 26.0a2
Firmware Version: US_20130912_QC211