Closed
Bug 925635
Opened 11 years ago
Closed 11 years ago
[LockScreen] Fix the track to match the icons
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(blocking-b2g:-, b2g-v1.2 fixed, b2g-v1.3 fixed)
RESOLVED
FIXED
blocking-b2g | - |
People
(Reporter: gweng, Assigned: gweng)
References
Details
Attachments
(1 file)
223 bytes,
text/html
|
timdream
:
review+
timdream
:
approval-gaia-v1.2+
|
Details |
Because of the wrong media-queue, currently the track won't extend enough to fit the icon's position on larger device.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gweng
Assignee | ||
Comment 1•11 years ago
|
||
Fixed the media queries.
Attachment #815739 -
Flags: review?(timdream)
Assignee | ||
Updated•11 years ago
|
blocking-b2g: --- → koi?
Updated•11 years ago
|
Attachment #815739 -
Flags: review?(timdream)
Attachment #815739 -
Flags: review+
Attachment #815739 -
Flags: approval-gaia-v1.2+
Comment 2•11 years ago
|
||
You have my a+ so please land this patch on master and v1.2. Thanks!
blocking-b2g: koi? → -
Flags: needinfo?(gweng)
Assignee | ||
Comment 3•11 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/41334990d9b7cfbb9415916c23f6930f2ddf63dc
Flags: needinfo?(gweng)
Assignee | ||
Comment 4•11 years ago
|
||
Tim: This patch should work together with Bug 923788, which is not koi? nor koi+ now. I've cherry-pick both them on my local repo and they worked fine. So should I tag the later as koi+, or cherry-pick it and send PR in other ways?
Flags: needinfo?(timdream)
Assignee | ||
Comment 7•11 years ago
|
||
I've sent the PR but Travis gone crazy, so I'll rerun it if it become better.
Assignee | ||
Comment 8•11 years ago
|
||
Travis still says what I can't get understand... ReferenceError: sanitize is not defined Wondering why I must encounter this...I just modified the lockscreen with 3 lines CSS!
Assignee | ||
Comment 9•11 years ago
|
||
v1.2: https://github.com/mozilla-b2g/gaia/commit/1fd315337d8ae891c3024e4c682c4c50797ea40e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
Please remember to set branch landing status flags when uplifting yourself.
status-b2g-v1.2:
--- → fixed
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to John Ford [:jhford] -- please use 'needinfo?' instead of a CC from comment #10) > Please remember to set branch landing status flags when uplifting yourself. Thanks a lot. I'll notice that next time.
Updated•10 years ago
|
status-b2g-v1.3:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•