Closed Bug 925635 Opened 11 years ago Closed 11 years ago

[LockScreen] Fix the track to match the icons

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:-, b2g-v1.2 fixed, b2g-v1.3 fixed)

RESOLVED FIXED
blocking-b2g -
Tracking Status
b2g-v1.2 --- fixed
b2g-v1.3 --- fixed

People

(Reporter: gweng, Assigned: gweng)

References

Details

Attachments

(1 file)

Because of the wrong media-queue, currently the track won't extend enough to fit the icon's position on larger device.
Assignee: nobody → gweng
Attached file Patch
Fixed the media queries.
Attachment #815739 - Flags: review?(timdream)
blocking-b2g: --- → koi?
Attachment #815739 - Flags: review?(timdream)
Attachment #815739 - Flags: review+
Attachment #815739 - Flags: approval-gaia-v1.2+
You have my a+ so please land this patch on master and v1.2. Thanks!
blocking-b2g: koi? → -
Flags: needinfo?(gweng)
Tim: This patch should work together with Bug 923788, which is not koi? nor koi+ now. I've cherry-pick both them on my local repo and they worked fine. So should I tag the later as koi+, or cherry-pick it and send PR in other ways?
Flags: needinfo?(timdream)
Bug 923788 comes with a+ too :)
Flags: needinfo?(timdream)
I've sent the PR but Travis gone crazy, so I'll rerun it if it become better.
Travis still says what I can't get understand...

    ReferenceError: sanitize is not defined

Wondering why I must encounter this...I just modified the lockscreen with 3 lines CSS!
v1.2: https://github.com/mozilla-b2g/gaia/commit/1fd315337d8ae891c3024e4c682c4c50797ea40e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Please remember to set branch landing status flags when uplifting yourself.
(In reply to John Ford [:jhford] -- please use 'needinfo?' instead of a CC from comment #10)
> Please remember to set branch landing status flags when uplifting yourself.

Thanks a lot. I'll notice that next time.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: