925712 - Back and forward buttons are shorter than other toolbar buttons

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Back and forward buttons are now centered vertically, but they should be stretched like other buttons.

Comment 1

[Mike de Boer [:mikedeboer]]

Comment on attachment 815816 [details] [diff] [review]
patch

Review of attachment 815816 [details] [diff] [review]:
-----------------------------------------------------------------

When I checked the patch on my (up-to-date) UX checkout, OSX, it broke the world. Did you check all platforms?

Comment 2

[Dão Gottwald [:dao]]

I checked Linux. I don't have OS X and it's unclear to me how this could break "the world". Can you attach a screenshot?

Comment 3

[Mike de Boer [:mikedeboer]]

(In reply to Dão Gottwald [:dao] from comment #2)
> I checked Linux. I don't have OS X and it's unclear to me how this could
> break "the world". Can you attach a screenshot?

'break the world' is a phrase I have adopted from Gijs... might be a bit excessive :)

Comment 4

[Mike de Boer [:mikedeboer]]

Attachment: 925712-alignment.png

Dze screenshot

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch v2

This should maintain current behavior on Windows and OS X.

Comment 6

[Mike de Boer [:mikedeboer]]

Dão, when trying this patch on Linux (Ubuntu Unity theme) I noticed that the height of the back/ forward buttons will be stretched to almost the full height of the navbar. I guess/ know that is intentional, but now the fact that the back button has no margin-end, thus hugs the urlbar, is really visible. Something to fix in this bug, or in a followup?

Meanwhile, I'm checking Windows...

Comment 7

[Dão Gottwald [:dao]]

(In reply to Mike de Boer [:mikedeboer] from comment #6)
> Dão, when trying this patch on Linux (Ubuntu Unity theme) I noticed that the
> height of the back/ forward buttons will be stretched to almost the full
> height of the navbar. I guess/ know that is intentional, but now the fact
> that the back button has no margin-end, thus hugs the urlbar, is really
> visible. Something to fix in this bug, or in a followup?

That's being fixed in bug 925710.

Comment 8

[Mike de Boer [:mikedeboer]]

Comment on attachment 815832 [details] [diff] [review]
patch v2

Review of attachment 815832 [details] [diff] [review]:
-----------------------------------------------------------------

Looking great, overal. Thanks!

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/projects/ux/rev/f3723f56cd27

Comment 10

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/f3723f56cd27