Closed
Bug 925712
Opened 11 years ago
Closed 11 years ago
Back and forward buttons are shorter than other toolbar buttons
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: regression, Whiteboard: [Australis:M9][Australis:P3])
Attachments
(2 files, 1 obsolete file)
40.24 KB,
image/png
|
Details | |
3.55 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
Back and forward buttons are now centered vertically, but they should be stretched like other buttons.
Attachment #815816 -
Flags: review?(mdeboer)
Comment 1•11 years ago
|
||
Comment on attachment 815816 [details] [diff] [review]
patch
Review of attachment 815816 [details] [diff] [review]:
-----------------------------------------------------------------
When I checked the patch on my (up-to-date) UX checkout, OSX, it broke the world. Did you check all platforms?
Attachment #815816 -
Flags: review?(mdeboer)
Updated•11 years ago
|
Flags: needinfo?(dao)
Assignee | ||
Comment 2•11 years ago
|
||
I checked Linux. I don't have OS X and it's unclear to me how this could break "the world". Can you attach a screenshot?
Flags: needinfo?(dao)
Comment 3•11 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #2)
> I checked Linux. I don't have OS X and it's unclear to me how this could
> break "the world". Can you attach a screenshot?
'break the world' is a phrase I have adopted from Gijs... might be a bit excessive :)
Comment 4•11 years ago
|
||
Dze screenshot
Assignee | ||
Comment 5•11 years ago
|
||
This should maintain current behavior on Windows and OS X.
Attachment #815816 -
Attachment is obsolete: true
Attachment #815832 -
Flags: review?(mdeboer)
Assignee | ||
Updated•11 years ago
|
Whiteboard: [Australis:M9][Australis:P3]
Comment 6•11 years ago
|
||
Dão, when trying this patch on Linux (Ubuntu Unity theme) I noticed that the height of the back/ forward buttons will be stretched to almost the full height of the navbar. I guess/ know that is intentional, but now the fact that the back button has no margin-end, thus hugs the urlbar, is really visible. Something to fix in this bug, or in a followup?
Meanwhile, I'm checking Windows...
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #6)
> Dão, when trying this patch on Linux (Ubuntu Unity theme) I noticed that the
> height of the back/ forward buttons will be stretched to almost the full
> height of the navbar. I guess/ know that is intentional, but now the fact
> that the back button has no margin-end, thus hugs the urlbar, is really
> visible. Something to fix in this bug, or in a followup?
That's being fixed in bug 925710.
Comment 8•11 years ago
|
||
Comment on attachment 815832 [details] [diff] [review]
patch v2
Review of attachment 815832 [details] [diff] [review]:
-----------------------------------------------------------------
Looking great, overal. Thanks!
Attachment #815832 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Whiteboard: [Australis:M9][Australis:P3] → [Australis:M9][Australis:P3][fixed-in-ux]
Comment 10•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P3][fixed-in-ux] → [Australis:M9][Australis:P3]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•