Closed Bug 925712 Opened 6 years ago Closed 6 years ago

Back and forward buttons are shorter than other toolbar buttons

Categories

(Firefox :: Toolbars and Customization, defect)

All
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: regression, Whiteboard: [Australis:M9][Australis:P3])

Attachments

(2 files, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Back and forward buttons are now centered vertically, but they should be stretched like other buttons.
Attachment #815816 - Flags: review?(mdeboer)
Comment on attachment 815816 [details] [diff] [review]
patch

Review of attachment 815816 [details] [diff] [review]:
-----------------------------------------------------------------

When I checked the patch on my (up-to-date) UX checkout, OSX, it broke the world. Did you check all platforms?
Attachment #815816 - Flags: review?(mdeboer)
Flags: needinfo?(dao)
I checked Linux. I don't have OS X and it's unclear to me how this could break "the world". Can you attach a screenshot?
Flags: needinfo?(dao)
(In reply to Dão Gottwald [:dao] from comment #2)
> I checked Linux. I don't have OS X and it's unclear to me how this could
> break "the world". Can you attach a screenshot?

'break the world' is a phrase I have adopted from Gijs... might be a bit excessive :)
Attached image 925712-alignment.png
Dze screenshot
Attached patch patch v2Splinter Review
This should maintain current behavior on Windows and OS X.
Attachment #815816 - Attachment is obsolete: true
Attachment #815832 - Flags: review?(mdeboer)
Whiteboard: [Australis:M9][Australis:P3]
Dão, when trying this patch on Linux (Ubuntu Unity theme) I noticed that the height of the back/ forward buttons will be stretched to almost the full height of the navbar. I guess/ know that is intentional, but now the fact that the back button has no margin-end, thus hugs the urlbar, is really visible. Something to fix in this bug, or in a followup?

Meanwhile, I'm checking Windows...
(In reply to Mike de Boer [:mikedeboer] from comment #6)
> Dão, when trying this patch on Linux (Ubuntu Unity theme) I noticed that the
> height of the back/ forward buttons will be stretched to almost the full
> height of the navbar. I guess/ know that is intentional, but now the fact
> that the back button has no margin-end, thus hugs the urlbar, is really
> visible. Something to fix in this bug, or in a followup?

That's being fixed in bug 925710.
Comment on attachment 815832 [details] [diff] [review]
patch v2

Review of attachment 815832 [details] [diff] [review]:
-----------------------------------------------------------------

Looking great, overal. Thanks!
Attachment #815832 - Flags: review?(mdeboer) → review+
http://hg.mozilla.org/projects/ux/rev/f3723f56cd27
Whiteboard: [Australis:M9][Australis:P3] → [Australis:M9][Australis:P3][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/f3723f56cd27
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P3][fixed-in-ux] → [Australis:M9][Australis:P3]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.