925804 - Marketplace web activity to open a target app details page from cold launch launches marketplace, but not the target app details page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jason Smith [:jsmith]]

Seen while doing marketplace integration into e.me testing.

When you select a marketplace app found in e.me search results, the marketplace app would open, but not the target app details page. Per the discussion on bug 910316, the e.me team is claiming this is a bug on the marketplace side on how they are handling web activity requests from a cold launch.

Still digging into why, but making sure I get a bug on file for this.

Comment 1

[Matt Basta [:basta]]

Has this been tested with the latest, updated version of the Marketplace package?

Comment 2

[Matt Basta [:basta]]

Also, can you provide code that demonstrates the failure?

Comment 3

[Jason Smith [:jsmith]]

(In reply to Matt Basta [:basta] from comment #1)
> Has this been tested with the latest, updated version of the Marketplace
> package?

It was tested with what is currently in Gaia.

https://github.com/mozilla-b2g/gaia/tree/master/external-apps/marketplace.firefox.com

(In reply to Matt Basta [:basta] from comment #2)
> Also, can you provide code that demonstrates the failure?

e.me team probably could help you with that.

Ran - Can you provide the relevant e.me code for when a user selects a marketplace suggestion in e.me search results?

Comment 4

[Christopher Van Wiemeersch [:cvan]]

As I mentioned in another bug, I have not updated the Marketplace .zip in gaia. I will do that. I wanted QA to verify the webactivities before upstreaming it to gaia.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/12799

Comment 7

[Jason Smith [:jsmith]]

Chris is updating the marketplace app in Gaia - so moving this over to Gaia.

Comment 8

[Jason Smith [:jsmith]]

Comment on attachment 816062 [details]
https://github.com/mozilla-b2g/gaia/pull/12799

etags and zip file look okay.

Can't check activities because I don't have the e.me code in question that triggers the activity over to marketplace. We need to land this update anyways, so we can do that post landing in the bug this blocks.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

Attachment: application.zip

Comment 10

[[:fabrice] Fabrice Desré]

Comment on attachment 816062 [details]
https://github.com/mozilla-b2g/gaia/pull/12799

Clearing review since we discussed some issues with cvan on irc.

Comment 11

[Christopher Van Wiemeersch [:cvan]]

Fabrice: I've updated https://github.com/cvan/gaia/blob/4c1661d/external-apps/marketplace.firefox.com/application.zip to fix this use case:

1) Get the latest Marketplace update or (via desktop b2g) install Marketplace packaged app: https://marketplace.firefox.com/app/marketplace/?region=worldwide
2) Launch in Browser: http://jsbin.com/USEHoGA/1
3) Marketplace is launched and we are navigated to Little Alchemy

…

4) Close Browser
5) In Marketplace app go back to homepage
6) Launch in Browser: http://jsbin.com/USEHoGA/1
7) Marketplace is focussed and we are navigated to Little Alchemy

Comment 12

[Caitlin Galimidi [:c8o]]

what's the next step on this bug?

Comment 13

[Christopher Van Wiemeersch [:cvan]]

Fabrice, when you get a minute, could please review this and (if all looks good) merge it in.

http://jsbin.com/EhEGEpe/2 is the test case. See comment 11, where I've outlined the steps to verify that I've addressed the issue you found per comment 10. Many thanks!

Comment 14

[[:fabrice] Fabrice Desré]

merged:
https://github.com/mozilla-b2g/gaia/commit/e1f84e045d47acdb58760a51a3d75a84395dd856

Comment 15

[Ran Ben Aharon [:ranbena] EverythingMe]

Christopher, I still cannot get the jsbin tests to work. The Marketplace app doesn't open :-/

Unagi, Gecko 27.0a1, Latest Gaia (ff127af)

Does it work on your device?

Comment 16

[Jason Smith [:jsmith]]

This has already landed & should not be reopened unless the patch is backed out.

Comment 17

[Jason Smith [:jsmith]]

File a followup if there's followup work needed here.

Comment 18

[Caitlin Galimidi [:c8o]]

jsmith: does the marketplace app details page open as expected?

Comment 19

[Jason Smith [:jsmith]]

(In reply to Caitlin Galimidi from comment #18)
> jsmith: does the marketplace app details page open as expected?

If it's not working as expected, file a followup bug for the issue you are seeing.

Comment 20

[Christopher Van Wiemeersch [:cvan]]

(In reply to Ran Ben Aharon (Everything.me) from comment #15)
> Christopher, I still cannot get the jsbin tests to work. The Marketplace app
> doesn't open :-/
> 
> Unagi, Gecko 27.0a1, Latest Gaia (ff127af)
> 
> Does it work on your device?

Does http://jsbin.com/EhEGEpe/2 launch the Marketplace for you?

Please file a follow up bug and point me to your jsbin tests. Thanks!