Closed
Bug 925871
Opened 11 years ago
Closed 11 years ago
add a helper function to click a row of a XUL tree element for the TB mozmill tests
Categories
(Thunderbird :: Testing Infrastructure, enhancement)
Thunderbird
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 28.0
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(1 file)
4.82 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
Add a helper function to click a row of a XUL tree element for the TB mozmill tests. There are some places where we need this. And it seems not all trees (if any) implement .contentView.getItemAtIndex(). So I propose a generic function working on all trees. This was inspired by bug 900541 where a tree row is just selected. I am not sure if that is 100% equivalent to a user clicking the row. In other places in tests we do more, e.g. synthesize a mouse event. So I propose to make this "more code" easily accessible in a helper function.
This is the proposal and it also converts 2 existing users to the new function. Aryx, could you please make a try build of this patch? All systems, mozmill tests only.
Attachment #816025 -
Flags: feedback?(archaeopteryx)
Comment on attachment 816025 [details] [diff] [review] patch Thanks Aryx. The tests seem to have passed: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=475d28daeffe I really forgot to note here, that this is to be applied on top of bug 900541.
Attachment #816025 -
Flags: feedback?(archaeopteryx) → review?(mconley)
Comment 3•11 years ago
|
||
Comment on attachment 816025 [details] [diff] [review] patch Review of attachment 816025 [details] [diff] [review]: ----------------------------------------------------------------- It looks fine, but those sleeps look suspicious. What's up with them? ::: mail/test/mozmill/shared-modules/test-folder-display-helpers.js @@ +920,5 @@ > + let column = aTree.columns[0]; > + aTree.treeBoxObject.getCoordsForCellItem(aRowIndex, column, "text", > + x, y, width, height); > + > + aController.sleep(0); What are the sleeps for? What are we pumping the event loop for?
Attachment #816025 -
Flags: review?(mconley)
No idea, but I am just moving that code around. It was already there. But I can imagine they are needed, we have some more places in tests that need such sleeps.
Comment 5•11 years ago
|
||
needinfo?ing myself to see if we can find a better solution than those sleeps.
Flags: needinfo?(mconley)
Comment 6•11 years ago
|
||
Comment on attachment 816025 [details] [diff] [review] patch Bah, poking at this again, I don't think it's worth the time to try to solve the sleep issue. If it was good enough before, I guess it'd good enough after. Thanks aceman!
Attachment #816025 -
Flags: review?(mconley) → review+
Yes, thanks.
Flags: needinfo?(mconley)
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/42a96b98eeec
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
Comment 9•11 years ago
|
||
Backed out for mozmill failures. https://hg.mozilla.org/comm-central/rev/6ec8a0de0567 https://tbpl.mozilla.org/php/getParsedLog.php?id=31107950&tree=Thunderbird-Trunk
Assignee | ||
Comment 10•11 years ago
|
||
Well, this passed tests before (comment 2) and the now failing tests have nothing to do with the patch. If you see the failures, the test couldn't click id=charsetMenu . I'd rather suspect bug 805374.
Flags: needinfo?(ryanvm)
Comment 11•11 years ago
|
||
Could be, your push was on a newer parent m-c rev than the previous push. Feel free to put checkin-needed back on the bug once it's confirmed to be a regression from m-c (assuming Standard8 doesn't want to close the tree).
Flags: needinfo?(ryanvm)
Comment 12•11 years ago
|
||
Still failing post-backout. Re-landed. https://hg.mozilla.org/comm-central/rev/20149c337716
You need to log in
before you can comment on or make changes to this bug.
Description
•