925894 - Windows b2g multilocale completely broken even on green runs on Win64-rev2

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=28993659&tree=Fx-Team is a red Windows b2g build, red for some unclear reason, but https://tbpl.mozilla.org/php/getParsedLog.php?id=28994302&tree=Fx-Team is a "green" run containing all the same errors as the "c:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/include/" path completely confuses things. https://tbpl.mozilla.org/php/getParsedLog.php?id=28978157&tree=Mozilla-Central, a recent m-c and thus not -rev2, doesn't have the same errors.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Normalize cl generated dependencies before testing for spaces in them

This is surely going to fix the "No rule to make target 'c:/Program'" part of this bug. No idea about the rest.

Landed on birch to assess.

Comment 2

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #1)
> Created attachment 817605 [details] [diff] [review]
> Normalize cl generated dependencies before testing for spaces in them
> 
> This is surely going to fix the "No rule to make target 'c:/Program'" part
> of this bug. No idea about the rest.

I should explain why I expect this to work: we skip dependencies with a space in them when gathering from cl -showIncludes output on the premise that they are system paths (and, well, they confuse make, as per this bug). The problem with the -rev2 builds is that various paths have been set in the short path form (c:\Progra~2\...). And what cl.py does to normalize paths actually transforms such paths back to the long form (c:\Program Files (x86)\...). But the test for spaces is done before the normalization, so those paths are not skipped anymore.

Comment 3

[John Hopkins (:jhopkins)]

Comment on attachment 817605 [details] [diff] [review]
Normalize cl generated dependencies before testing for spaces in them

https://hg.mozilla.org/integration/mozilla-inbound/rev/df950d461d3e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df950d461d3e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/faec76c7d010
https://hg.mozilla.org/releases/mozilla-esr24/rev/58fb08e34722

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/faec76c7d010