Windows b2g multilocale completely broken even on green runs on Win64-rev2

RESOLVED FIXED

Status

task
RESOLVED FIXED
6 years ago
Last year

People

(Reporter: philor, Assigned: glandium)

Tracking

({regression})

unspecified
x86_64
Windows Server 2008
Dependency tree / graph

Firefox Tracking Flags

(firefox26 fixed, firefox27 fixed, firefox-esr24 fixed, b2g-v1.2 fixed)

Details

Attachments

(1 attachment)

https://tbpl.mozilla.org/php/getParsedLog.php?id=28993659&tree=Fx-Team is a red Windows b2g build, red for some unclear reason, but https://tbpl.mozilla.org/php/getParsedLog.php?id=28994302&tree=Fx-Team is a "green" run containing all the same errors as the "c:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/include/" path completely confuses things. https://tbpl.mozilla.org/php/getParsedLog.php?id=28978157&tree=Mozilla-Central, a recent m-c and thus not -rev2, doesn't have the same errors.
Depends on: 926035
This is surely going to fix the "No rule to make target 'c:/Program'" part of this bug. No idea about the rest.

Landed on birch to assess.
Attachment #817605 - Flags: review?(gps)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
(In reply to Mike Hommey [:glandium] from comment #1)
> Created attachment 817605 [details] [diff] [review]
> Normalize cl generated dependencies before testing for spaces in them
> 
> This is surely going to fix the "No rule to make target 'c:/Program'" part
> of this bug. No idea about the rest.

I should explain why I expect this to work: we skip dependencies with a space in them when gathering from cl -showIncludes output on the premise that they are system paths (and, well, they confuse make, as per this bug). The problem with the -rev2 builds is that various paths have been set in the short path form (c:\Progra~2\...). And what cl.py does to normalize paths actually transforms such paths back to the long form (c:\Program Files (x86)\...). But the test for spaces is done before the normalization, so those paths are not skipped anymore.
Attachment #817605 - Flags: review?(gps) → review+
Comment on attachment 817605 [details] [diff] [review]
Normalize cl generated dependencies before testing for spaces in them

https://hg.mozilla.org/integration/mozilla-inbound/rev/df950d461d3e
Attachment #817605 - Flags: checked-in+
https://hg.mozilla.org/mozilla-central/rev/df950d461d3e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
You need to log in before you can comment on or make changes to this bug.