925907 - Check for IN_SELECT_IN_TABLE in "reset the insertion mode" in HTML5 parser.

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[William Chen [:wchen]]

"reset the insertion mode" implementation for handling the select element should be updated to match the spec.

http://www.w3.org/html/wg/drafts/html/master/syntax.html#reset-the-insertion-mode-appropriately

Comment 1

[William Chen [:wchen]]

Attachment: Check for IN_SELECT_IN_TABLE in "reset the insertion mode" in HTML5 parser.

Comment 2

[Henri Sivonen (:hsivonen)]

Comment on attachment 816055 [details] [diff] [review]
Check for IN_SELECT_IN_TABLE in "reset the insertion mode" in HTML5 parser.

Looks right according to http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#reset-the-insertion-mode-appropriately

Thanks.

(I'd rather not read the W3C copy, since the editors are changing stuff too lightly. Hopefully they have the sense not to make their mark on the parsing algorithm, but reading the WHATWG copy anyway to be sure.)

Comment 3

[William Chen [:wchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/253257d650a6

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/253257d650a6

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Seems like something that needs a test. Can someone check if the html5lib repo has one, at least?

Comment 6

[William Chen [:wchen]]

(In reply to :Ms2ger from comment #5)
> Seems like something that needs a test. Can someone check if the html5lib
> repo has one, at least?

There is a test for this in the upstream html5lib repo.