Closed Bug 925907 Opened 6 years ago Closed 6 years ago

Check for IN_SELECT_IN_TABLE in "reset the insertion mode" in HTML5 parser.

Categories

(Core :: HTML: Parser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: wchen, Assigned: wchen)

References

()

Details

Attachments

(1 file)

"reset the insertion mode" implementation for handling the select element should be updated to match the spec.

http://www.w3.org/html/wg/drafts/html/master/syntax.html#reset-the-insertion-mode-appropriately
Comment on attachment 816055 [details] [diff] [review]
Check for IN_SELECT_IN_TABLE in "reset the insertion mode" in HTML5 parser.

Looks right according to http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#reset-the-insertion-mode-appropriately

Thanks.

(I'd rather not read the W3C copy, since the editors are changing stuff too lightly. Hopefully they have the sense not to make their mark on the parsing algorithm, but reading the WHATWG copy anyway to be sure.)
Attachment #816055 - Flags: review?(hsivonen) → review+
https://hg.mozilla.org/mozilla-central/rev/253257d650a6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Seems like something that needs a test. Can someone check if the html5lib repo has one, at least?
Flags: in-testsuite- → in-testsuite?
(In reply to :Ms2ger from comment #5)
> Seems like something that needs a test. Can someone check if the html5lib
> repo has one, at least?

There is a test for this in the upstream html5lib repo.
You need to log in before you can comment on or make changes to this bug.