If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

firefox os form fails to submit if description is empty

RESOLVED FIXED

Status

Input Graveyard
Submission
P2
normal
RESOLVED FIXED
4 years ago
8 months ago

People

(Reporter: willkg, Assigned: willkg)

Tracking

Details

(Whiteboard: u=user c=feedback p=1 s=input.2013q4)

If there's no description, then the Firefox OS form fails to submit and the user ends up in a weird loop they may not understand.

STR:

1. go to https://input.allizom.org/en-US/feedback/firefox.fxos.stable/
2. click on Next over and over again until you get to submit
3. click on Submit feedback

Expected:

If you're on the description card and click on next without anything in the description, then it should show an error.
I didn't fix this because I thought I'd have to introduce a new error string and that's problematic from an l10n perspective this late in the cycle.

However, it occurs to me we could just prevent the Next button from doing anything if the input consists solely of whitespace or is an empty string. That'd work fine.
In a PR: https://github.com/mozilla/fjord/pull/176
This was pretty easy. Making it a 1 pointer.
Whiteboard: u=user c=feedback p= s=input.2013q4 → u=user c=feedback p=1 s=input.2013q4
Landed in master in https://github.com/mozilla/fjord/commit/c5909d1
Pushed to stage and prod just now.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → willkg
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.