925973 - firefox os form fails to submit if description is empty

Status: RESOLVED FIXED

(Input Graveyard :: Submission, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

If there's no description, then the Firefox OS form fails to submit and the user ends up in a weird loop they may not understand.

STR:

1. go to https://input.allizom.org/en-US/feedback/firefox.fxos.stable/
2. click on Next over and over again until you get to submit
3. click on Submit feedback

Expected:

If you're on the description card and click on next without anything in the description, then it should show an error.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I didn't fix this because I thought I'd have to introduce a new error string and that's problematic from an l10n perspective this late in the cycle.

However, it occurs to me we could just prevent the Next button from doing anything if the input consists solely of whitespace or is an empty string. That'd work fine.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/176

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was pretty easy. Making it a 1 pointer.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/fjord/commit/c5909d1

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed to stage and prod just now.