Closed Bug 926069 Opened 7 years ago Closed 7 years ago

CacheFile must not create new entry when key is a hash

Categories

(Core :: Networking: Cache, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: michal, Assigned: michal)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Attached patch fix (obsolete) — Splinter Review
We have to fail when key is a hash and the entry cannot be successfully read from the disk.
Attachment #816246 - Flags: review?(honzab.moz)
Comment on attachment 816246 [details] [diff] [review]
fix

Review of attachment 816246 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab for cache2 preffed off.
Attachment #816246 - Flags: review?(honzab.moz) → review+
Attached patch final patchSplinter Review
Assignee: nobody → michal.novotny
Attachment #816246 - Attachment is obsolete: true
Attachment #8339569 - Flags: review+
Attachment #8339569 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/10abe767a26b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
This has not landed, Michal you managed to land an empty patch.  Please reland, now the patch is just on gum.
Status: RESOLVED → REOPENED
Flags: needinfo?(michal.novotny)
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/1559f81806fb
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Keywords: verifyme
Can you please provide a testcase QA can use to verify this fix?
Flags: needinfo?(michal.novotny)
(In reply to Ioana Budnar, QA [:ioana] from comment #8)
> Can you please provide a testcase QA can use to verify this fix?

This bug cannot be verified since the code which calls CacheFile::Init() with aKeyIsHash == true is unused (and always was). Btw, this flag will be removed completely soon.
Flags: needinfo?(michal.novotny)
Keywords: verifyme
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.