926118 - tracking flags are being cleared when making a change to a bug using the webservice api after tracking flag migration

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[David Lawrence [:dkl]]

https://bugzilla.mozilla.org/show_bug.cgi?id=637806
https://bugzilla.mozilla.org/show_bug.cgi?id=675297
https://bugzilla.mozilla.org/show_bug.cgi?id=751539

Seems to be same flags as well each time:
status-firefox16: affected → ---
status-firefox17: affected → ---
status-firefox18: affected → ---
status-firefox19: affected → ---

Looking at the code, bug_end_of_update only works on active flags and does not mess with inactive flags so I am not sure why this is happening yet.

dkl

Comment 1

[David Lawrence [:dkl]]

tbplbot is using the following to call BzAPI to update the bug adding a comment:

https://hg.mozilla.org/webtools/tbpl/file/4b9bf20dad6a/php/submitBugzillaComment.php#l24

Will try this locally to see what is occurring. Could be an issue in how BzAPI is calling process_bug.cgi to update the bug directly.

dkl

Comment 2

[David Lawrence [:dkl]]

Sigh, not just inactive flags it seems:

https://bugzilla.mozilla.org/show_bug.cgi?id=910435#c40

Comment 3

[David Lawrence [:dkl]]

Committed a fix for this issue and will need to be pushed to prod as soon as possible.

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified extensions/TrackingFlags/Extension.pm
Committed revision 9059. 

We will also need to look into a script to replace tracking flags removed in the time period after the migration by tbplbot when it added comments.

dkl

Comment 4

[David Lawrence [:dkl]]

We may be able to do it by hand if it is not too many. Here is what I see so far.

http://dkl.pastebin.mozilla.org/3247322

dkl

Comment 5

[:glob ✱]

this appears to have impacted more than just api-driven changes; see bug 914888 comment 9 and bug 495123 comment 45.

Comment 6

[David Lawrence [:dkl]]

Attachment: 926118_1.patch

Comment 7

[:glob ✱]

Comment on attachment 816649 [details] [diff] [review]
926118_1.patch

Review of attachment 816649 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

::: extensions/TrackingFlags/Extension.pm
@@ +491,5 @@
> +
> +    foreach my $flag (@$tracking_flags) {
> +        my $flag_name = $flag->name;
> +        if (defined $params->{$flag_name}
> +             || defined $params->{"defined_$flag_name"})

nit: there's no need to check for defined_, as trackingflags aren't multiselect.

Comment 8

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified extensions/TrackingFlags/Extension.pm
Committed revision 9063. 

dkl