926180 - UserInterface__getAllResults is SLOW

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Arpad Borsos [:Swatinem]]

When I was profiling in bug 920149 i noticed that UserInterface__updateFailingBuildsDisplay takes a lot of time due to the slowness in UserInterface__getAllResults.

There are 5 nested .forEach’s in there, which are really killing the performance.

Sacrificing a little memory usage in order to be able to quickly iterate over a linear array should be a good tradeoff.

Comment 1

[Arpad Borsos [:Swatinem]]

Attachment: Use a flat results array

So chromes profiles, devtools’ profiler and firebugs profiler all say a lot of different stuff and a lot of noise, but according to firebug this went down from ~240ms to ~23 ms, a 10x speedup! :-)

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 816344 [details] [diff] [review]
Use a flat results array

Review of attachment 816344 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thank you :-)

Comment 3

[Ed Morley [:emorley]]

In production :-)