92624 - "Unsubscribe" context-menuitem should be "Unsubscribe..."

Status: VERIFIED WONTFIX

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Håkan Waara]

The subscribe context-menuitem should be "Subscribe..." because it requires an
extra command from the user (the confirmation) before it unsubscribes you.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

clarifying summary.  I've got a potential fix.  Jglick, let me know if this is okay.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Fix.

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Wait, that only fixes the menu-item, not the context menu.  Both of them need
doing.  Next, I'll attach a combined patch.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Complete Patch.

Comment 5

[Håkan Waara]

Thanks. r=hwaara

Comment 6

[(not reading, please use [e-mail] instead)]

that's not what the spec (or 4.x) has.

http://www.mozilla.org/mailnews/specs/threepane/MailMenus.html
http://www.mozilla.org/mailnews/specs/threepane/MailMenus.html#standalone

based on the spec, this bug is invalid.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Or, this bug can be morphed into "No ellipsis should be present on the Newsgroup
context-menu for Subscribe..." because the spec clearly shows that it isn't
supposed to be there.  See the next attachment.  

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Spec for both news account and news group levels

Comment 9

[Håkan Waara]

This bug is not invalid, the spec is wrong.

Based on previous discussions with jglick participating, we (and all HIGs agree
here) use an ellipsis after menuitems that _does need more input from the user
before they are being processed_. In this case, it won't subscribe you
immediately but bring up a confirm dialog.

Comment 10

[(not reading, please use [e-mail] instead)]

stephend, I'm confused.  "Subscribe..." is in the spec and in the product.

hwaara, I'm not sure sure about that.  but we'll have to wait for jglick to respond.

since she's overloaded and this is a trival bug, it might be a while.
I'm thinking this is wontfix.

Comment 11

[jglick]

I'm sorry, the spec part for "Newsgroups" is incorrect. "Subscribe..." should 
have the elipsis because it opens a dialog that requires the user's input. 
"Unsubscribe" should Not have the elipsis because the action is immediate.

Fixing spec. This bug is only valid if there is someplace in the product with 
"Subscribe" instead of "Subscribe...".

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

Seth - http://www.mozilla.org/mailnews/specs/threepane/MailMenus.html#standalone
tells me that:

Inbox
Trash
Sent, Drafts, Template
News Server (account level)
All *have* the ellipsis.

However, in that same spec (refer to my screenshot of the spec for the news
context menus, or
http://www.mozilla.org/mailnews/specs/threepane/MailMenus.html#standalone)
clearly, the group level itself for news doesn't have an ellipsis.

Comment 13

[Håkan Waara]

No it's not. You require the user to click "Unsubscribe" or optionally Cancel
the operation.

Menuitems which causes operations that are processed immediately, does not give
any choice to cancel.

Comment 14

[(not reading, please use [e-mail] instead)]

ah, I see it.

in the spec we've got the "Subscribe" is in the folder pane context menu for
newsgroups.

in the app, we do "Subscribe..." so we're ok. 

so the problem is the spec is wrong.  sounds like jglick is going to fix the spec.

based on jglick's comments, this bug is wontfix.

Comment 15

[Håkan Waara]

This bug is about that "Unsubscribe" should be "Unsubscribe..." because it
doesn't immediately remove the newsgroup; it asks the user if it really wants to
do it (confirm) first.

This should be reopened.

Comment 16

[jglick]

Confirmation dialogs don't count. 

Windows Interface Guidelines, page 137. "Do not include an ellipsis for a 
command that may result in the display of a message box."  

Message box as defined on page 210, includes the types: Information, Warning, 
Critical or Question.

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

verified.  thanks for the good explanation, Jennifer.