926286 - TabsToolbar is missing its bottom border in fullscreen mode without a lightweight theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Matthew N. [:MattN]]

Attachment: Screenshot: ux-8ffe0cddfb33_49_twoPinnedWithOverflow_fullScreen_onlyNavBar_noLWT.png

STR:
1) Use the default theme (no LWT)
2) Enter OS X fullscreen (unsure if it affects old 10.6 fullscreen)

Expected result:
border at the bottom of the tabstrip

Actual result:
No tabstrip border (see screenshot)

Very likely a regression from bug 924182.

Comment 1

[Matthew N. [:MattN]]

Oops, forgot the regression range:
Last good nightly: 2013-10-07
First bad nightly: 2013-10-08

Pushlog:
http://hg.mozilla.org/projects/ux/pushloghtml?fromchange=18fd395752cd&tochange=aa03fbc1149f

Comment 2

[:Gijs (he/him)]

Attachment: draw the tabstoolbar border ourselves in fullscreen,

This WFM.

Comment 3

[Markus Stange [:mstange]]

Does something cover the titlebar border in fullscreen mode or does Core just not draw it?

Comment 4

[:Gijs (he/him)]

(In reply to Markus Stange [:mstange] from comment #3)
> Does something cover the titlebar border in fullscreen mode or does Core
> just not draw it?

I suppose I went on the assumption that core doesn't draw it, but perhaps that assumption is broken.

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 816499 [details] [diff] [review]
draw the tabstoolbar border ourselves in fullscreen,

Review of attachment 816499 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Matthew N. [:MattN] from comment #0)
> 2) Enter OS X fullscreen (unsure if it affects old 10.6 fullscreen)

BTW, this does affect 10.6 fullscreen.

(In reply to Markus Stange [:mstange] from comment #3)
> Does something cover the titlebar border in fullscreen mode or does Core
> just not draw it?

AFAICT, it is not drawn in this case.

::: browser/themes/osx/browser.css
@@ +2557,2 @@
>   */
> +#main-window[sizemode="fullscreen"] #TabsToolbar::after,

I worry that there will be inconsistency between the line the OS draws and that which our CSS draws (now and in the future) but that is more of a comment on bug 924182.

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/b37c23af0b3b

Comment 7

[Matthew N. [:MattN]]

Thanks for the quick turnaround on the bug! :)

Comment 8

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/b37c23af0b3b