Closed Bug 926330 Opened 7 years ago Closed 7 years ago

Make DirPickerFileListBuilderTask threading assertion fatal

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

As agreed on IRC, spinning off from bug 923922 comment 8 to address any further issues that need to be addressed after the landing of that bug.
Attached patch patchSplinter Review
Attachment #816479 - Flags: review?(bugs)
Comment on attachment 816479 [details] [diff] [review]
patch


>-        mInput->SetFileListProgress(mFileList.Length());
>+        mFileListLength = mFileList.Length();
>+        if (mCanceled) {
>+          NS_ASSERTION(!mInput, "This is bad - how did this happen?");
Use MOZ_ASSERT here
Attachment #816479 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdbcdd02794e
Blocks: 923922
Summary: Further review comments on DirPickerBuildFileListTasks cancelling → Make DirPickerFileListBuilderTask threading assertion fatal
https://hg.mozilla.org/mozilla-central/rev/bdbcdd02794e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.