Closed
Bug 926330
Opened 11 years ago
Closed 11 years ago
Make DirPickerFileListBuilderTask threading assertion fatal
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
15.18 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
As agreed on IRC, spinning off from bug 923922 comment 8 to address any further issues that need to be addressed after the landing of that bug.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #816479 -
Flags: review?(bugs)
Comment 2•11 years ago
|
||
Comment on attachment 816479 [details] [diff] [review] patch >- mInput->SetFileListProgress(mFileList.Length()); >+ mFileListLength = mFileList.Length(); >+ if (mCanceled) { >+ NS_ASSERTION(!mInput, "This is bad - how did this happen?"); Use MOZ_ASSERT here
Attachment #816479 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdbcdd02794e
Blocks: 923922
Summary: Further review comments on DirPickerBuildFileListTasks cancelling → Make DirPickerFileListBuilderTask threading assertion fatal
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bdbcdd02794e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•