Closed Bug 926397 Opened 6 years ago Closed 6 years ago

Red-on-black tooltips on Ubuntu are hard to read

Categories

(DevTools :: Object Inspector, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: past, Assigned: past)

Details

Attachments

(3 files)

Attached image red-on-black.png
Our property descriptor tooltip is hard to read on Ubuntu's default theme, as can be seen in the attached screenshot. We have to make it brighter.
Assignee: nobody → past
Status: NEW → ASSIGNED
Comment on attachment 816554 [details] [diff] [review]
Make property descriptor tooltips easier to read on Linux

Review of attachment 816554 [details] [diff] [review]:
-----------------------------------------------------------------

You guys use non-Ubuntu Linux systems with non-default themes if I am not mistaken, so could you tell me if this works for you?
Attachment #816554 - Flags: review?(paul)
Attachment #816554 - Flags: review?(mihai.sucan)
Attachment #816554 - Flags: review?(paul) → review+
Maybe force the background to a lighter color and thus be sure it'll work regardless of the default theme?
I'm afraid that a light tooltip background would look out of place, since all other apps use the dark one.
Our tools don't really try to respect the system theme though :) But I don't feel strongly about it.
Comment on attachment 816554 [details] [diff] [review]
Make property descriptor tooltips easier to read on Linux

Review of attachment 816554 [details] [diff] [review]:
-----------------------------------------------------------------

this is better, but why do we need to make this text red?
Attachment #816554 - Flags: review?(mihai.sucan) → review+
(In reply to Victor Porof [:vp] from comment #6)
> Our tools don't really try to respect the system theme though :) But I don't
> feel strongly about it.

But we never modify the tooltip background in Firefox either to my knowledge, so I dunno :-)

(In reply to Mihai Sucan [:msucan] from comment #7)
> this is better, but why do we need to make this text red?

This is a legitimate question, I think Victor just wanted to make false attributes more prominent and harder to miss. Not sure how important this is.
I found black crossed out text to not entirely stand out from ordinary text, in which case "non-enumerable" might be confused as actually being "enumerable". The subtle red helped.
Let's get this simple fix in and keep thinking about whether it makes sense to change the tooltip background or the red color:

https://hg.mozilla.org/integration/fx-team/rev/50abdc9ee405
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/50abdc9ee405
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.