926397 - Red-on-black tooltips on Ubuntu are hard to read

Status: RESOLVED FIXED

(DevTools :: Object Inspector, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: red-on-black.png

Our property descriptor tooltip is hard to read on Ubuntu's default theme, as can be seen in the attached screenshot. We have to make it brighter.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Make property descriptor tooltips easier to read on Linux

This looks much better on my system.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: The new look

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 816554 [details] [diff] [review]
Make property descriptor tooltips easier to read on Linux

Review of attachment 816554 [details] [diff] [review]:
-----------------------------------------------------------------

You guys use non-Ubuntu Linux systems with non-default themes if I am not mistaken, so could you tell me if this works for you?

Comment 4

[Victor Porof [:vporof][:vp]]

Maybe force the background to a lighter color and thus be sure it'll work regardless of the default theme?

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

I'm afraid that a light tooltip background would look out of place, since all other apps use the dark one.

Comment 6

[Victor Porof [:vporof][:vp]]

Our tools don't really try to respect the system theme though :) But I don't feel strongly about it.

Comment 7

[Mihai Sucan [:msucan]]

Comment on attachment 816554 [details] [diff] [review]
Make property descriptor tooltips easier to read on Linux

Review of attachment 816554 [details] [diff] [review]:
-----------------------------------------------------------------

this is better, but why do we need to make this text red?

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Victor Porof [:vp] from comment #6)
> Our tools don't really try to respect the system theme though :) But I don't
> feel strongly about it.

But we never modify the tooltip background in Firefox either to my knowledge, so I dunno :-)

(In reply to Mihai Sucan [:msucan] from comment #7)
> this is better, but why do we need to make this text red?

This is a legitimate question, I think Victor just wanted to make false attributes more prominent and harder to miss. Not sure how important this is.

Comment 9

[Victor Porof [:vporof][:vp]]

I found black crossed out text to not entirely stand out from ordinary text, in which case "non-enumerable" might be confused as actually being "enumerable". The subtle red helped.

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

Let's get this simple fix in and keep thinking about whether it makes sense to change the tooltip background or the red color:

https://hg.mozilla.org/integration/fx-team/rev/50abdc9ee405

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/50abdc9ee405