926422 - [B2G][Helix][WIFI][wangyuguo]How to cofiguration the wifi signal strength level in gaia both state bar and wifi AP list?

Status: RESOLVED INVALID

(Firefox OS Graveyard :: General, defect, P1)

Description

[lecky]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; aff-kingsoft-ciba; .NET4.0C; .NET4.0E)

Steps to reproduce:

1)Use the wifi signal instrument to generate wifi signal;
2)Watch the wifi signal strength level on the four level;


Actual results:

The signal is too denseness between level 2 and level 3;
signal strength    signal level
  RSSI < -92              0
-88≤ RSSI <-77          1
-77≤ RSSI <-66          2
-66≤ RSSI < -58         3
-58 ≤RSSI                 4


Expected results:

signal strength    signal level
  RSSI < -88              0
-88≤ RSSI <-82          1
-82≤ RSSI <-75          2
-75≤ RSSI < -65         3
-65 ≤RSSI                 4

Comment 1

[Wayne Chang [:wchang]]

Evelyn,

Can you point them where this is?

Comment 2

[Evelyn Hung]

Settings:
var level = Math.min(Math.floor(network.relSignalStrength / 20), 4);
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/settings/js/wifi.js#L241

System (status bar):
icon.dataset.level = Math.ceil(voice.relSignalStrength / 20); // 0-5
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/system/js/statusbar.js#L505

Comment 3

[lecky]

So,I should modify in both file.Another method is modify the function of calculateSignal in gecko/dom/wifi/Wifiworker.js like the attachment, this method can solve the probelm too, but I am not sure whether cause other problem,so could you help to check and give some advice?

Comment 4

[Evelyn Hung]

Vincent, do you think the problem is kind of hardware tuning?

Comment 5

[Vincent Chang[:vchang][changyihsin]]

If I read the code correctly, the calculate formula for wifi signal status bar should be here.
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/system/js/statusbar.js#L608
icon.dataset.level = Math.floor(relSignalStrength / 25);

But in Settings, it is 
var level = Math.min(Math.floor(network.relSignalStrength / 20), 4);
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/settings/js/wifi.js#L241

Maybe we should sync both. 

You can fine tune the calculate formula in gecko in 
http://dxr.mozilla.org/mozilla-central/source/dom/wifi/WifiWorker.js?from=wifiworker.js%20#l1299

Comment 6

[Evelyn Hung]

(In reply to Vincent Chang[:vchang] from comment #5)
> If I read the code correctly, the calculate formula for wifi signal status
> bar should be here.
> https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/system/js/statusbar.
> js#L608
> icon.dataset.level = Math.floor(relSignalStrength / 25);
The link you provided doesn't point to the code above. I see the formula is on master, not on v1.1.
> 
> But in Settings, it is 
> var level = Math.min(Math.floor(network.relSignalStrength / 20), 4);
> https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/settings/js/wifi.
> js#L241
> 
> Maybe we should sync both. 
As my comment 2 pointed out, they are synced.

Comment 7

[lecky]

OK,The method to modify the function of calculateSignal in gecko/dom/wifi/Wifiworker.js,please help to check.

Comment 8

[lecky]

Attachment: FFOS -WIFI signal modify check.rar

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 821559 [details]
FFOS -WIFI signal modify check.rar

I CANNOT READ IT.  Do your own encrypted thing at home.

Comment 10

[lecky]

I have send password to you by emial.

Comment 11

[lecky]

I also found that the wifi signal strength can not updata in statusbar, that could cause differnt with WIFI ap list(updata 10 seconds).

Comment 12

[Evelyn Hung]

(In reply to lecky from comment #10)
> I have send password to you by emial.

No, you can't work in this way, Bugzilla is public. If you think your patch is confidential, please ask for a confidential bug.

Comment 13

[Alan Huang]

(In reply to Evelyn Hung [:evelyn] from comment #12)
> (In reply to lecky from comment #10)
> > I have send password to you by emial.
> 
> No, you can't work in this way, Bugzilla is public. If you think your patch
> is confidential, please ask for a confidential bug.

Add some more:
If you are asking for review, suppose you expected your patch will be checked in after you got r+. Then your patch still goes to public. So why there's a confidential patch asking for here?