926464 - Manifest parser should recognize capitalized constants: skip-if = True doesn't work, skip-if = true does

Status: RESOLVED WONTFIX

(Testing :: Mozbase, defect)

Description

[:Gijs (he/him)]

As per summary.

Especially because the moz.build documentation says you can use the constants "True", "False" and "None", and the test manifest documentation on MDN doesn't say anything, so I assumed I should use the capitalized versions and just wasted a couple of hours of try machine time and my own sanity trying to figure out what was up.

</rant>

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Not sure if we should actually support it, but we should error out fast

Comment 2

[(not currently active) Ted Mielczarek]

I'd support erroring better here and fixing the docs. I did document the expression syntax in the manifestparser docs:
http://mozbase.readthedocs.org/en/latest/manifestdestiny.html#manifest-conditional-expressions

Comment 3

[Geoff Brown [:gbrown]]

Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is still a problem which needs to be fixed. The mentioned docs can now be found at:

https://firefox-source-docs.mozilla.org/mozbase/manifestparser.html#manifest-conditional-expressions

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

as we are on .toml, we do not support "True" as a valid value.