926487 - Replace className comparisons with classList.contains in viewSource.js

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

+++ This bug was initially created as a clone of Bug #926479 +++

+++ This bug was initially created as a clone of Bug #926477 +++

+++ This bug was initially created as a clone of Bug #926471 +++

See the following search for each instance of this: http://mxr.mozilla.org/mozilla-central/search?string=.className+%3D%3D&find=viewSource.js&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

If someone adds a new className to the element, these checks will fail. They should instead be using .classList.contains().

Comment 1

[Marco]

Can this bug be assigned to me please? Thanks

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Marco, do you have any update on this?

Comment 3

[Marco]

Fixed the bug, running the tests now.

Comment 4

[Marco]

Wein, I updated it, but I'm not sure if i did it the right way (my first one). And I updated the bug 926477 for Rene Amrhein ([e-mail] as well.
Thanks for your feedback.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Marco, I don't see any attachment on this bug. Can you please upload a patch that fixes it to this bug and flag me for review? (On the Add an Attachment page you'll want to set the "review" field to "?" and then put in ":jaws" as the reviewer.)

Comment 6

[Marco]

Hi, I committed it again, just the bug 926487. I used mercurial queue:
hg qnew bug-926487-fix.patch
hg qrefresh -m "comment"
hg commit

Hopefully it worked. I it is not allowed to add you to the sec-review flag:

"Jared Wein [:jaws] <[e-mail]> does not have permission to set the sec-review flag. Please select a user who is a member of the nightwatch group."

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

To upload the patch you should click on the "Add an Attachment" link in this bug. You can then find your patch in the .hg/patches folder of your local repository. It should be named "bug-926487-fix.patch".

Comment 8

[Marco]

Attachment: Replace className comparisons

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8344186 [details] [diff] [review]
Replace className comparisons

Review of attachment 8344186 [details] [diff] [review]:
-----------------------------------------------------------------

This patch is indenting the fixed code changed in a previous commit on your local machine. You can generate a patch from a commit by running:
hg log -r revisionNumber -p > 926487.patch
where revisionNumber is the changeset revision number of the commit. The patch will be a file in your current directory named 926487.patch.

Comment 10

[Marco]

Attachment: 926487.patch

Revision-number:156938:30645bc7c00a

Comment 11

[Marco]

Attachment: 926487.patch

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

I'm sorry, I didn't do a good job of describing what should be done for this bug. Marco, can you take a look at this patch and let me know if you agree with what I have changed?

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/09c25b7e92c1

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/09c25b7e92c1

Comment 15

[Marco]

Everything okey

Comment 16

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8346626 [details] [diff] [review]
Patch

Thanks!