Feedback can't handle the unicode

VERIFIED FIXED in 2013-10-28

Status

Marketplace
API
P1
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: robhudson, Assigned: mat)

Tracking

Avenir
2013-10-28
x86
Mac OS X
Points:
---

Details

(Reporter)

Description

5 years ago
http://sentry.mktmon.services.phx1.mozilla.com/mkt/marketplacefirefoxcom/group/611/

UnicodeDecodeError 'ascii' codec can't decode byte 0xc3 in position 52: ordinal not in range(128)

Stacktrace (most recent call last):

  File "tastypie/resources.py", line 192, in wrapper
    response = callback(request, *args, **kwargs)
  File "tastypie/resources.py", line 397, in dispatch_list
    return self.dispatch('list', request, **kwargs)
  File "mkt/api/base.py", line 104, in dispatch
    .dispatch(request_type, request, **kwargs))
  File "tastypie/resources.py", line 427, in dispatch
    response = method(request, **kwargs)
  File "tastypie/resources.py", line 1165, in post_list
    updated_bundle = self.obj_create(bundle, request=request, **self.remove_api_resource_names(kwargs))
  File "mkt/account/api.py", line 229, in obj_create
    self._send_email(bundle)
  File "mkt/account/api.py", line 190, in _send_email
    recipient_list=[settings.MKT_FEEDBACK_EMAIL])
  File "amo/utils.py", line 286, in send_mail_jinja
    msg = send_mail(subject, template.render(**context), *args, **kwargs)
  File "jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)
  File "./mkt/account/templates/account/email/feedback.txt", line 20, in top-level template code
    {{ feedback }}
(Reporter)

Updated

5 years ago
Priority: -- → P1
(Reporter)

Updated

5 years ago
Assignee: nobody → mpillard
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → 2013-10-28
(Assignee)

Comment 1

5 years ago
Fixed in https://github.com/mozilla/zamboni/commit/85c7201a019b350a69e73ffbd312e705589c90ed

STR:
- Load the marketplace on -dev
- Click "Feedback" in the footer
- Leave a feedback containing some non-ascii characters, such as "é".
- Verify that it submits the feedback correctly instead of saying "There was a problem submitting your feedback"
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 2

5 years ago
Verified as fixed in https://marketplace-dev.allizom.org/ on FF27 (Win 7).
Postfix screencast http://screencast.com/t/NsxcauA0Hz
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.