Closed
Bug 926583
Opened 11 years ago
Closed 11 years ago
nsZipHeader.cpp:136:37 [-Wbitwise-op-parentheses] '&' within '|'
Categories
(Core :: Networking: JAR, defect)
Core
Networking: JAR
Tracking
()
RESOLVED
FIXED
mozilla27
| Tracking | Status | |
|---|---|---|
| firefox26 | --- | unaffected |
| firefox27 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [qa-])
Attachments
(1 file)
|
1.03 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
The following clang compiler warning is a regression from bug 921227. The current code is correct, but clang is warning that the bitwise & operator has a higher precedence than the bitwise | operator. modules/libjar/zipwriter/src/nsZipHeader.cpp:136:37 [-Wbitwise-op-parentheses] '&' within '|'
Attachment #816729 -
Flags: review?(taras.mozilla)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 816729 [details] [diff] [review] fix-nsZipHeader-warning.patch Review of attachment 816729 [details] [diff] [review]: ----------------------------------------------------------------- I'll let Mossop verify this
Attachment #816729 -
Flags: review?(taras.mozilla) → review?(dtownsend+bugmail)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 816729 [details] [diff] [review] fix-nsZipHeader-warning.patch Review of attachment 816729 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, sorry about that.
Attachment #816729 -
Flags: review?(dtownsend+bugmail) → review+
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2140cb2f2fcd
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2140cb2f2fcd
Assignee: nobody → cpeterson
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•